Tcl Source Code

View Ticket
Login
Ticket UUID: 448625
Title: Sun 5.6 LD_SEARCH_FLAG setting incorrect
Type: Patch Version: None
Submitter: pahoughton Created on: 2001-08-07 01:07:08
Subsystem: 53. Configure and Build Tools Assigned To: nobody
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2001-08-23 01:59:31
Resolution: Works For Me Closed By: hobbs
    Closed on: 2001-08-22 18:59:31
Description:
In unix/tcl.m4 the setting of LD_SEARCH_FLAG for SunOS
5.6 is 
incorrect if  gcc is not being used. The problem is
resolved for
5.7 and 5.8, but was not implemented for 5.6 and below.

Heres the Patch:

diff -rc tcl8.3.3-orig/unix/tcl.m4 tcl8.3.3/unix/tcl.m4
*** tcl8.3.3-orig/unix/tcl.m4Fri Apr  6 12:51:46 2001
--- tcl8.3.3/unix/tcl.m4Mon Aug  6 18:57:26 2001
***************
1042
      DL_OBJS="tclLoadDl.o"
      DL_LIBS="-ldl"
      LDFLAGS=""
!     LD_SEARCH_FLAGS='-Wl,-R,${LIB_RUNTIME_DIR}'
      ;;
  SunOS-5*)
      SHLIB_CFLAGS="-KPIC"
--- 1036,1046 ----
      DL_OBJS="tclLoadDl.o"
      DL_LIBS="-ldl"
      LDFLAGS=""
!     if test "$using_gcc" = "yes" ; then
!     LD_SEARCH_FLAGS='-Wl,-R,${LIB_RUNTIME_DIR}'
!     else
! LD_SEARCH_FLAGS='-R ${LIB_RUNTIME_DIR}'
!     fi
      ;;
  SunOS-5*)
      SHLIB_CFLAGS="-KPIC"
User Comments: hobbs added on 2001-08-23 01:59:31:
Logged In: YES 
user_id=72656

cc  tclAppInit.o -L/export/home/jeffh/build/tcl84a4 -
ltcl8.4 -ldl  -lsocket -lnsl -lm -lc \
        -Wl,-R,/home/jeffh/install/solaris-sparc/lib -o 
tclsh
sparky [~/build/tcl84a4] 27 > which cc
/opt/SUNWspro/bin/cc
sparky [~/build/tcl84a4] 28 > uname -a
SunOS sparky 5.6 Generic_105181-26 sun4u sparc SUNW,Ultra-
5_10

and most notably:

sparky [~/build/tcl84a4] 31 > ldd -s ./tclsh

   find library=libtcl8.4.so; required by ./tclsh
    search path=/home/jeffh/install/solaris-sparc/lib  
(RPATH from file ./tclsh)
    trying path=/home/jeffh/install/solaris-
sparc/lib/libtcl8.4.so
    search path=/usr/lib  (default)
    trying path=/usr/lib/libtcl8.4.so
        libtcl8.4.so =>  (file not found)

Shows that Solaris cc does pick up the file regardless.  
The patch seems OK, but if it just unnecessarily 
complicates things, why apply it?

pahoughton added on 2001-08-07 08:07:09:

File Added - 9311: tcl8.3.3-pah.src.patch

Attachments: