Ticket UUID: | 426197 | |||
Title: | windows RC tool already defines a macro | |||
Type: | Patch | Version: | None | |
Submitter: | davygrvy | Created on: | 2001-05-22 06:57:22 | |
Subsystem: | 53. Configure and Build Tools | Assigned To: | davygrvy | |
Priority: | 5 Medium | Severity: | ||
Status: | Closed | Last Modified: | 2002-06-18 08:40:02 | |
Resolution: | Duplicate | Closed By: | davygrvy | |
Closed on: | 2002-06-18 01:40:02 | |||
Description: |
The use of the RESOURCE_INCLUDED macro in the Tcl and Tk header files could be replaced by RC_INVOKED. See http://msdn.microsoft.com/library/default.asp? URL=/library/psdk/winui/rc_89wz.htm for the proof of the existance of this macro. I don't see any reason to define our own from within the .rc files. | |||
User Comments: |
davygrvy added on 2002-06-18 08:40:02:
Logged In: YES user_id=7549 resolved in Feature Request #565088. davygrvy added on 2002-06-08 07:14:44: File Deleted - 6539: mdejong added on 2001-11-09 11:39:47: Logged In: YES user_id=90858 Asigning back to davygrvy, I just don't know enough about Windows resource files to review this one. mdejong added on 2001-10-05 04:18:56: Logged In: YES user_id=90858 I took a look at this before, but to be honest I don't know much about Windows resource files. Perhaps this patch should be assigned to another reviewer. davygrvy added on 2001-10-05 02:38:04: File Added - 11571: tclPatchRC.txt Logged In: YES user_id=7549 The macro cut-off point should be higher up in tcl.h, and I had missed the JOIN and STRINGIFY macros earlier. davygrvy added on 2001-05-22 13:57:59: File Added - 6540: patch.txt davygrvy added on 2001-05-22 13:57:23: File Added - 6539: patch.txt |