Tcl Source Code

If TclInExit is called very late in the finalize 
sequence, the thread specific data has been freed 
already, and TclInExit returns the wrong value (and in 
fact re-initialises the thread specific data).  The 
patch below fixes this problem.

TclKit can, under some circumstances, run into this 
bug.


$ diff -r -C3 tcl8.4/generic/tclEvent.c 
tcl8.4v/generic/tclEvent.c
*** tcl8.4/generic/tclEvent.c   Sat Mar 31 08:57:31 
2001
--- tcl8.4v/generic/tclEvent.c  Thu Feb  1 15:21:47 
2001
***************
*** 935,942 ****
  int
  TclInExit()
  {
!     ThreadSpecificData *tsdPtr = TCL_TSD_INIT
(&dataKey);
!     return tsdPtr->inExit;
  }
  ^L
  /*
--- 935,946 ----
  int
  TclInExit()
  {
!     ThreadSpecificData *tsdPtr = TclThreadDataKeyGet
(&dataKey);
!     if (tsdPtr == NULL) {
!       return inFinalize;
!     } else {
!       return tsdPtr->inExit;
!     }
  }
  ^L
  /*

File Added - 34814: patch

Logged In: YES 
user_id=90858

Jeff mentioned that this patch was related to the problem I
was having.
I ended up solving it by splitting the normal and per thread
exit
status up into two functions so that one could tell when Tcl
was finalizing itself in a callback registered by
Tcl_CreateExitHandler.
The patch I checked in is attached.

Logged In: YES 
user_id=72656

fixed in core-8-3-1-branch and 8.4a4cvs head.

File Added - 10604: tclEvent.patch

Logged In: YES 
user_id=32170

Ok, a patch is attached.

Logged In: YES 
user_id=80530

Can you attach the patch, rather than include it
in the comment?