Tcl Source Code

View Ticket
Login
Ticket UUID: 415648
Title: Doc, CONSTify, and unify Tcl_*Panic*
Type: Patch Version: CONSTify
Submitter: dgp Created on: 2001-04-12 12:26:36
Subsystem: 50. Embedding Support Assigned To: dgp
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2002-02-08 16:04:38
Resolution: Accepted Closed By: dkf
    Closed on: 2002-02-08 09:04:38
Description:
New man page doc/Panic.3 documents Tcl_Panic,
Tcl_PanicVA, Tcl_SetPanicProc, panic, panicVA, and
Tcl_PanicProc.  (Bugs 219170, 414936).
User Comments: dgp added on 2001-06-16 06:33:52:

File Added - 7396: tclppanic.patch

Logged In: YES 
user_id=80530

Dan Steffen pointed out to me that the patches so far
break wish on the Mac.  The patches so far had the effect
of requiring Mac applications that embed Tcl to call
Tcl_SetPanicProc() with a suitable panic handler
in order to have panic messages reported visibly.  This
would be an incompatible change.

So, I'm uploading another supplemental patch that corrects
this problem.  It defines an internal routine TclpPanic()
that is a platform-specific panic handler.  It is actually
implemented only on the Mac, so that Mac applications that
continue not to call Tcl_SetPanicProc() will still have
a suitable platform-specific handler provided by the Tcl
internals.  On Unix and Windows, TclpPanic is NULL.

Committing to HEAD and uploading this supplemental patch.

dgp added on 2001-06-14 07:41:56:

File Added - 7311: mac.patch

Logged In: YES 
user_id=80530

Attached and committed to HEAD a supplemental patch
for the Macintosh from Dan Steffen.

dgp added on 2001-06-09 03:07:50:
Logged In: YES 
user_id=80530

Committed to HEAD.

dgp added on 2001-04-19 01:10:31:
Logged In: YES 
user_id=80530

Not sure why the system converted this from "Patch"
to "Bug".  Changing it back...

dgp added on 2001-04-19 01:09:26:

File Added - 5513: Panic.3

Logged In: YES 
user_id=80530

Take 2

dgp added on 2001-04-19 01:07:04:

File Deleted - 5267: 

Logged In: YES 
user_id=80530

Corrected typos in doc/Panic.3

andreas_kupries added on 2001-04-18 21:53:08:
Logged In: YES 
user_id=75003

Wah, never work from memory. It is describing, not
description:

Panic.3:
50c50
< \fIformat\fB argument is a format string decribing how to
format the
---
> \fIformat\fB argument is a format string describing how to
format the

andreas_kupries added on 2001-04-18 21:48:47:
Logged In: YES 
user_id=75003

The manpage looks good, except for a small nit: "decription"
should be "description". The code seems to be ok too, but I
can't speak about the Mac changes.

dgp added on 2001-04-18 07:29:44:

File Deleted - 5268: 



File Added - 5489: panic.patch

dgp added on 2001-04-18 07:29:43:
Logged In: YES 
user_id=80530

Updated patch (forgot 'make mklinks' the first time).

Any comments?

dgp added on 2001-04-12 19:31:03:

File Added - 5268: panic.patch

dgp added on 2001-04-12 19:31:02:
Logged In: YES 
user_id=80530

Added patch that CONSTifies (TIP 27) the Tcl_*Panic*
procedures.  Also tries to significantly rework the
Tcl_*Panic* procedures on the Mac, so that all platforms use
the same generic routines.  These changes need checking and
probably more work by someone with a Mac.  Please review.

dgp added on 2001-04-12 19:26:41:

File Added - 5267: Panic.3

Attachments: