Tcl Source Code

our company uses tcl as the primary interface to our EDA tools.  we make use of Tcl_CreateTrace() in order to generate a history log (or "replay script") of commands invoked when using a tool.  

in migrating from tcl 8.0 to tcl 8.3.2 we found we hit the same problem described in bug#119362.  this caused major problems in our history log, but for other reasons we had to move forward to with this version upgrade.

given my limited knowledge with the inner workings of the tcl interpretter code, i'll go out on a limb by saying our patch appears to be "a clean fix" (as opposed to a hacky or kludgy workaround).  at least i didn't see any negative repercussions when evaluating the patch inside a debugger...

even with the patch, the 'command' argument that gets passed into the tclTrace callback is not exactly the same as it was in tcl v8.0.  things like comments are now included, as well as trailing "\n"'s - but in my company we've deemed this to be a desirable "feature" and not a bug.

this is the first time my company has had to patch tcl code, so you'll have to forgive me if i'm not providing this patch in the right manner or format.

we're hoping this patch will be considered for integration into a future tcl release...

Logged In: YES 
user_id=148712

The patch has been adapted to the current HEAD and moved to
the bug ticket #219362.

Logged In: YES 
user_id=148712

Bug number is now 219362; see related patch #403430

Two points.  Firstly, it is easiest for us if you generate your patches using "cvs diff -u" against some version.  Your change is only a one-line one, so it doesn't matter too much in this case, but for anything larger it is much easier to do it that way.

Secondly, and more relevantly for you, that file has changed significantly between 8.3.2 and the current development version.  Can you try it out and get back to us if your fix is rendered unnecessary?  If so, we can make sure that if/when 8.3.3 gets done, we change that too (providing nobody else objects.)

Thank you very much all the same for taking the trouble to submit the fix.  We do appreciate it.