Tcl Source Code

Edited to shorten paths:

generic/tclInt.h:4358:12: warning: incompatible pointer types passing 'Tcl_Size *' (aka 'long *') to parameter of type 'int *' [-Wincompatible-pointer-types]
    return TclGetIntFromObj(interp, objPtr, sizePtr);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
generic/tclInt.h:2757:46: note: expanded from macro 'TclGetIntFromObj'
            : Tcl_GetIntFromObj((interp), (objPtr), (intPtr)))
                                                    ^~~~~~~~
generic/tclDecls.h:152:27: note: passing argument to parameter 'intPtr' here
                                Tcl_Obj *objPtr, int *intPtr);

> should Tcl just check sizeof(…) instead?

It doesn't really matter (IMHO), but since TCL_SIZE_MAX is non-C-standard it would be - slightly - better.

Closing. [e94242449556e1fd]

The patch I attached was superseded by [2e65fce4cf]. But should Tcl be assuming that TCL_SIZE_MAX == INT_MAX implies sizeof(Tcl_Size) == sizeof(int)? Since the condition is no longer meant for the preprocessor, should Tcl just check sizeof(…) instead?

The warning is about how C considers pointers to different integer types to be incompatible, regardless of whether the types have the same size.

TCL_SIZE_MAX == INT_MAX does not necessarily mean Tcl_Size is int. Using a temporary int avoids the warning; see attached patch.