Ticket UUID: | 3544932 | |||
Title: | Visual studio compiler check fails | |||
Type: | Bug | Version: | obsolete: 8.6b3 | |
Submitter: | decosterjos | Created on: | 2012-07-17 07:23:19 | |
Subsystem: | 53. Configuration and Build Tools | Assigned To: | patthoyts | |
Priority: | 9 Immediate | Severity: | Minor | |
Status: | Closed | Last Modified: | 2013-08-22 09:42:46 | |
Resolution: | Fixed | Closed By: | dkf | |
Closed on: | 2013-08-22 09:42:46 | |||
Description: |
When using the makefile.vc in the win directory to build Tcl or the thread and itcl packages, there is a check to see if the build is configured to build with Microsoft Visual Studio/C. This check is not complete (e.g fails when using Visual Studio Express 10 and SDK 7.1 to build 64 bit). The attached patches remove the check. When you're using the makeifle.vc to build Tcl/Itcl/Thread, you'll need nmake, which is only available when the VC build environment is configured. Jos. | |||
User Comments: |
nijtmans added on 2012-07-17 21:25:44:
Fixed in Tcl and Tk (all open branches), thread, tdbc and itcl. Jos, please veryfy whatever you can (I don't have a 64-bit build environment) decosterjos added on 2012-07-17 19:51:56: This should be added to the test in the different makefile.vc files: && !defined(WINDOWSSDKDIR) (note the upper case). Want me to make a patch for this change or if the line above sufficient? decosterjos added on 2012-07-17 19:39:05: I'll prepare a patch after testing. decosterjos added on 2012-07-17 19:37:26: That should do it. Same change needed in itcl and thread. nijtmans added on 2012-07-17 19:34:44: So, how about adding && !defined(WindowsSDKDir) to the end of the existing check. Does that work, or are additional changes needed? decosterjos added on 2012-07-17 19:29:30: Hi Jan, While I agree on that, I could not see what would be a good candidate to add in the VC-express + SDK setup. These are available: INCLUDE (has a list of VC include paths) LIBS or LIBPATH (list of VC lib paths) WindowsSDKDir nijtmans added on 2012-07-17 19:22:21: I have doubts about this one: If the 64-bit compiler has different macro's, shouldn't that be tested for, in stead of simply removing the check? Pat, you seem to be the expert in this. decosterjos added on 2012-07-17 14:24:06: File Added - 449114: makefile.vc.thread.patch decosterjos added on 2012-07-17 14:23:24: File Added - 449113: makefile.vc.tcl.patch |