Tcl Source Code

View Ticket
Login
Ticket UUID: 3405652
Title: --enable-dtrace on Sol10 (x86) fails
Type: Bug Version: obsolete: 8.5.10
Submitter: igalic Created on: 2011-09-07 15:34:51
Subsystem: 53. Configuration and Build Tools Assigned To: das
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2011-09-14 01:29:18
Resolution: Accepted Closed By: dgp
    Closed on: 2011-09-13 18:29:18
Description:
I haven't tested Sol9 or Sparc yet, but for this

"/home/igalic/mgar/pkg/tcl/trunk/work/solaris10-i386/build-isa-i386/tcl8.5.10/unix/../unix/tclUnixCompat.c", line 296: warning: statement not reached
"/home/igalic/mgar/pkg/tcl/trunk/work/solaris10-i386/build-isa-i386/tcl8.5.10/unix/../unix/tclUnixCompat.c", line 352: warning: statement not reached
"/home/igalic/mgar/pkg/tcl/trunk/work/solaris10-i386/build-isa-i386/tcl8.5.10/unix/../unix/tclUnixCompat.c", line 420: warning: statement not reached
"/home/igalic/mgar/pkg/tcl/trunk/work/solaris10-i386/build-isa-i386/tcl8.5.10/unix/../unix/tclUnixCompat.c", line 483: warning: statement not reached
rm -f libtclstub8.5.a
ar cr libtclstub8.5.a tclStubLib.o  ; ranlib libtclstub8.5.a
/usr/sbin/dtrace -G  -o tclDTrace.o -s /home/igalic/mgar/pkg/tcl/trunk/work/solaris10-i386/build-isa-i386/tcl8.5.10/unix/../generic/tclDTrace.d regcomp.o regexec.o regfree.o regerror.o tclAlloc.o tclAsync.o tclBasic.o tclBinary.o tclCkalloc.o tclClock.o tclCmdAH.o tclCmdIL.o tclCmdMZ.o tclCompCmds.o tclCompExpr.o tclCompile.o tclConfig.o tclDate.o tclDictObj.o tclEncoding.o tclEnv.o tclEvent.o tclExecute.o tclFCmd.o tclFileName.o tclGet.o tclHash.o tclHistory.o tclIndexObj.o tclInterp.o tclIO.o tclIOCmd.o tclIORChan.o tclIOGT.o tclIOSock.o tclIOUtil.o tclLink.o tclListObj.o tclLiteral.o tclLoad.o tclMain.o tclNamesp.o tclNotify.o tclObj.o tclPanic.o tclParse.o tclPathObj.o tclPipe.o tclPkg.o tclPkgConfig.o tclPosixStr.o tclPreserve.o tclProc.o tclRegexp.o tclResolve.o tclResult.o tclScan.o tclStringObj.o tclStrToD.o tclThread.o tclThreadAlloc.o tclThreadJoin.o tclThreadStorage.o tclStubInit.o tclStubLib.o tclTimer.o tclTrace.o tclUtf.o tclUtil.o tclVar.o tclTomMathInterface.o tclUnixChan.o tclUnixEvent.o tclUnixFCmd.o tclUnixFile.o tclUnixPipe.o tclUnixSock.o tclUnixTime.o tclUnixInit.o tclUnixThrd.o tclUnixCompat.o tclUnixNotfy.o  tclLoadDl.o 
dtrace: failed to compile script /home/igalic/mgar/pkg/tcl/trunk/work/solaris10-i386/build-isa-i386/tcl8.5.10/unix/../generic/tclDTrace.d: line 27: syntax error near "Tcl_Obj"
gmake[2]: *** [tclDTrace.o] Error 1
gmake[2]: Leaving directory `/home/igalic/mgar/pkg/tcl/trunk/work/solaris10-i386/build-isa-i386/tcl8.5.10/unix'
gmake[1]: *** [build-work/solaris10-i386/build-isa-i386/tcl8.5.10/unix/Makefile] Error 2
User Comments: dgp added on 2011-09-14 01:29:18:

allow_comments - 1

dgp added on 2011-09-14 01:29:17:
Patch accepted for all release branches

igalic added on 2011-09-08 17:32:49:
This patch by Dagobert Michelson fixes the reported behaviour and compiles, links and passes tests. (Solaris 10 i386 and amd64 are what I have tested so far.)

igalic added on 2011-09-08 17:31:15:

File Added - 423081: tcl-dtrace.patch

igalic added on 2011-09-08 12:23:34:
Here's a bit more info about the system I'm trying to build on:

igalic@unstable10x ~ % dtrace -V
dtrace: Sun D 1.3
igalic@unstable10x ~ % pkginfo -l SUNWdtrp
   PKGINST:  SUNWdtrp
      NAME:  DTrace Providers
  CATEGORY:  system
      ARCH:  i386
   VERSION:  11.10.0,REV=2005.01.21.16.34
   BASEDIR:  /
    VENDOR:  Sun Microsystems, Inc.
      DESC:  Dynamic Tracing (DTrace) Providers
    PSTAMP:  on10ptchfeatx20100805214310
  INSTDATE:  Sep 14 2010 11:37
   HOTLINE:  Please contact your local service provider
    STATUS:  completely installed
     FILES:       38 installed pathnames
                   5 shared pathnames
                  12 linked files
                   5 directories
                  14 executables
                1471 blocks used (approx)

igalic@unstable10x ~ % uname -a
SunOS unstable10x 5.10 Generic_142910-17 i86pc i386 i86pc Solaris
igalic@unstable10x ~ % cat /etc/release
                    Oracle Solaris 10 9/10 s10x_u9wos_14a X86
     Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
                            Assembled 11 August 2010
igalic@unstable10x ~ % cc -V
cc: Sun C 5.9 SunOS_i386 Patch 124868-15 2010/08/11

dgp added on 2011-09-08 01:19:54:
Thanks, das!

Comments on ticket 1793984 suggest
the problem here is using a version of
DTrace that was out of date in 2007.
"(fixed in SXDE 5/07)"

Try updating that to see if it solves
the issue.

das added on 2011-09-08 01:08:53:
1793984 has the details on which version of Solaris was tested at the time the patch was committed. I know that some older Solaris versions had bugs in DTrace support that caused problems, but can't recall the details at this point.
No time to look into this for the forseeable future (don't have a solaris install anymore)

dgp added on 2011-09-07 23:33:55:
Repro'd in Tcl releases 8.5.10 and 8.5.0.

Suspect some regression in the DTrace
facility itself on Solaris?  I can't imagine
DTrace feature was committed to Tcl broken
since day one.

dgp added on 2011-09-07 22:47:05:
Is this a new failure in 8.5.10 ?

Attachments: