Tcl Source Code

View Ticket
Login
Ticket UUID: 3168398
Title: TIP #285 perf changes
Type: Patch Version: TIP Implementation
Submitter: mistachkin Created on: 2011-01-30 22:24:00
Subsystem: 45. Parsing and Eval Assigned To: mistachkin
Priority: 5 Medium Severity:
Status: Open Last Modified: 2011-01-31 07:33:55
Resolution: None Closed By:
    Closed on:
Description:
These changes are designed to optimize (and modularize) the TIP #285 features.
User Comments: ferrieux added on 2011-01-31 07:33:55:
Bottom line: should be confirmed with more extensive tclbench runs, but it superficially looks like Joe's patch are an absolute Good Thing, and are orthogonal to the NRE slowdown.

ferrieux added on 2011-01-31 07:32:46:
Timings on non-NRE variant.


01:28]ferrieuxtiming results for 285 patch on 86-without-nre:
sansnre285.res:565905 microseconds per iteration
sansnre285.res:572837 microseconds per iteration
sansnre285.res:569185 microseconds per iteration
sansnre285.res:568799 microseconds per iteration
sansnre.res:618944 microseconds per iteration
sansnre.res:619809 microseconds per iteration
sansnre.res:615293 microseconds per iteration
sansnre.res:622320 microseconds per iteration
[01:28]mistachkinferrieux : now, it's "real fast"
[01:29]ferrieuxhave not computed the ratios, but yeah, that sounds orthogonal to nre

ferrieux added on 2011-01-31 07:31:55:

File Added - 400288: TIP285-rev2-trunk-with-no-nre.diff

ferrieux added on 2011-01-31 07:30:57:
Timings on NRE:


23:50]ferrieuxon one specific test, it is impressive:
 head285.res:647968 microseconds per iteration
 head285.res:646554 microseconds per iteration
 head285.res:626336 microseconds per iteration
 head285.res:642746 microseconds per iteration

 head.res:733830 microseconds per iteration
 head.res:711075 microseconds per iteration
 head.res:718664 microseconds per iteration
 head.res:702698 microseconds per iteration
[23:50]ferrieuxfirst with patch, second without. 4 runs.

ferrieux added on 2011-01-31 05:30:18:
Attaching pstack sampling results.

pid5971 is 8.6HEAD (Jan25)
pid12410 has your TIP285rev2 patch

both are from a 10-mn run over idiotloop2.tcl

ferrieux added on 2011-01-31 05:29:44:

File Added - 400283: sampling.tgz

mistachkin added on 2011-01-31 05:28:52:

File Added - 400282: TIP285-rev2.diff

mistachkin added on 2011-01-31 05:28:33:

File Deleted - 400281:

mistachkin added on 2011-01-31 05:24:01:

File Added - 400281: TIP285-rev2.diff

Attachments: