Tcl Source Code

Attached is patch making changes to configure.in

Apply and run autoconf to get the HEAD ready
to produce Thread 2.6.7.

allow_comments - 1

see 3383288

New release candidate for Thread 2.6.7 now
ready for testing:

     ftp://ftp.tcl.tk/pub/tcl/thread/thread2.6.7rc1.tar.gz

TEA 3.9 had more changes, all related to
AC_PROG_INSTALL().  Committed changes
copied over from "sampleextension" to keep
compatible.

committed that patch after testing found
it effective.

Testers currently report 3 other issues:

1) Compiler warnings about passing integer
values where a pointer type is expected.  This
is a common safe thing done in the Tcl world.
The issue is just to surpress the warning.

2) Updates to rules.vc are needed to support VC10.

3) `make test` crashes in the --with-aolserver configuration.

I think we need to fix 2) before releasing 2.6.7.  It would be
good to fix the other matters too, but if that's difficult or otherwise
undesirable, I don't think they need to block the release.

Tested thread2.6.7rc0.tar.gz as part of a build of Tcl CVS-HEAD today, using MSVC6 and MSVC9.  Builds, installs and runs thread test suite with no problems.

Attached vc.patch is meant to make the
released distributions have the proper
placement and contents of the "vc" files.

The test release that would come from 
HEAD + this patch is available for testing 
over at ftp://ftp.tcl.tk/pub/tcl/thread/thread2.6.7rc0.tar.gz

Testing and comments appreciated.

File Added - 393487: vc.patch

Hmmm,,, according to my knowledge you need the cvs commit support for Tcl
for doing anything here (I might be wrong). Only admins of the Tcl Project 
can grant this privilege. I cannot I'm, afraid.

A file move is IIRC a cvs checkin in the new place followed by the
cvs delete in the old place (CVS should keep the old file under Attic
to be able to build old(er) releases. This again requires cvs commit priv.

So anybody who wants to help needs Tcl commit righrs (I do not know
if this can be reduced just to the extension branch).

I am sure at least one TCT memver and TCl project admin is reading
these posts...

Oh man, who selected this tiny font here??? I am starting to lose my eyes :-(

I'm quite willing to make and test the changes, but:
(1) At the moment I don't think I have commit access to the repository.  I have provided the necessary patch some comments down, or someone can give me rights.
(2) The change involves moving files from the 'vc' direction to its parent.  I don't know the preferred way to do this in CVS for this project.

I have a slight problem with Windows...

Apart from the general disliking of the platform as a whole 
(which is another story) I do not have any possibility of 
getting anything done there. First, I lack the time, then the 
knowledge, the resources (machine/OS) and last (but not
the least) the fun of doing it. 

Anybody is more then welcome to help.

Seems to work fine for me, but I don't think
twylite's issues are fully addressed yet.

I'll be testing now; will report what I find.  Thanks!

There you go! I have no Windows box to check that part but Unix builds should be ok.
If all is well I can close this ticket?

I don't understand what compatibility concerns
you have.  Just concerned about those who
(re-)run autoconf for themselves?

OK. I wss not sure about the backward compatiblity.

You've already (implicitly) updated the tclconfig/*
files themselves.  All I'm asking is you make the
corresponding changes to configure.in so we stop
getting bogus warnings from every configure.

Will this be backward compatible with old systems that 
used to complile previous version?

The patch attached to this Tracker item
has not been applied

(TEA_INIT([3.7]) --> TEA_INIT([3.9]) and related changes).

Heh???


2010-09-28 Zoran Vasiljevic <[email protected]>

        * generic/threadCmd.c: Initialize tsdPtr->interp to NULL immediately after
        releasing the interp on thread-exit that should hopefully resolve the 
        Tcl Bug #3026061

        * generic/threadCmd.c: Removed safe-init so safe-interps should not be 
        able to run thread commands directly.

        * lib/ttrace.tcl: Changed version to 2.6.7 to be in sync with main pkg.

        * configure.in: Bumped version to 2.6.7 and autoconf'ed.

You do not see this in ChangeLog?

I see the upgrade to TEA 3.9 changes are still
not committed.  Anything they're waiting on?

> "how-to-make-a-release" memory... 

tag, export, `make dist`

Jos Decoster and I mentioned on tcl-core that Thread's makefile.vc is in the wrong folder (for Tcl's makefile.vc to find it).  A quick glance at the tracker suggests that neither of us have submitted a patch yet.  

If you're making a 2.6.7 release that is supposed to work in pkgs/ , this is probably the time to make such a change.

The contents of the vc/ folder need to be moved up into the win/ folder, then the following change applied to win/makefile.vc :

--
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 makefile.vc
--- makefile.vc 31 Aug 2010 17:50:58 -0000      1.1.1.1
+++ makefile.vc 28 Sep 2010 21:54:41 -0000
@@ -191,7 +191,7 @@
 #-------------------------------------------------------------------------

 BINROOT                = .
-ROOT            = ..\..
+ROOT            = ..

 PRJIMPLIB      = $(OUT_DIR)\$(PROJECT)$(VERSION)$(SUFX).lib
 PRJLIBNAME     = $(PROJECT)$(VERSION)$(SUFX).$(EXT)
--

If you'd prefer this submitted as a separate bug please yell.

This will have to wait until tomorrow. I need to refresh my
"how-to-make-a-release" memory...

I suggest a "Release Candidate" we can try out
in tcl/pkgs/ before making the formal 2.6.7 release.

Ah... this memory leak is not there. I was fooled by the per-default tclshell as 
distributed in Mac OSX. It is non-threaded or something else is wrong there so
it leaks grossly. A fresh 8.4 in thread-build and 2.6.7 threadinf extension is absoluely clean w.r.t. memory leaking.

I added 2.6.7 to ttrace.tcl and to configure.in and autoconf'ed.
I also fixed two minor bugs.
BUT....
Thera is a HUGE memory leak w.r.t thread creation/teardown.
It is absolutely unclear to me why! Our private fork that I maintain
for our needs works fine. So I need to see what caused this leak
first before actually doing any release :-(

Hi Zoran. Just ran into a bug when building Tcl 8.6+pkgs/ (CVS Head).
The Ttrace package in the semi-released 2.6.6 used in the Tcl8.6 pkgs/ directory
reports itself as 2.6.5, i.e. is in conflict with the data in pkgIndex.tcl.

This seems to have been fixed in the CVS of Thread, but not in a real release.

Adding my voice here in support of a 2.6.7 release which has all the version numbers fixed and straight.

Without I have to add local patches to my checkout to get something working after the build.

New patch gets the win/vc/pkg.vc update as well.

File Added - 385388: 3056785.patch

Please make sure that win\vc\pkg.vc is updated as well.

See Bug #3057497

I noticed that "Thread 2.6.6" that got tagged
several month ago never got actual release
archive stuck over in the Files area.  I've just
done that.

File Added - 385115: update.patch