Ticket UUID: | 3010352 | |||
Title: | make all TclOO API functions MODULE_SCOPE | |||
Type: | RFE | Version: | None | |
Submitter: | nijtmans | Created on: | 2010-06-02 09:24:36 | |
Subsystem: | 35. TclOO Package | Assigned To: | dkf | |
Priority: | 5 Medium | Severity: | Minor | |
Status: | Closed | Last Modified: | 2013-08-27 11:24:09 | |
Resolution: | Fixed | Closed By: | jan.nijtmans | |
Closed on: | 2013-08-27 11:24:09 | |||
Description: |
Because dkf (rightfully) only supports accessing those functions through the stub table, there is no need to export them from the dll. dkf wrote in [Tcl Bug #2965424] comments > I also only support it if it is compiled with > stub support; people building statically > are unsupported (and there's certainly no > ABI migration strategy there in any case) So, why not make them all MODULE_SCOPE, then the only way to access them is through the stub table. Here is a patch doing that. The genStubs.tcl modification is taken over from tdbc. It is influenced as well by Joe english (see Patch #941042 remarks), so I guess that Joe and Kevin will be happy as well about this change. | |||
User Comments: |
nijtmans added on 2011-09-28 15:33:35:
Committed to trunk. Also, here is a new patch for TclOO (8.5 version) doing the same, therefore re-assigning to dkf. nijtmans added on 2011-09-28 15:25:54: File Added - 424696: tcloo.diff nijtmans added on 2011-09-28 15:24:49: File Deleted - 405554: nijtmans added on 2011-09-21 19:16:07: Available now in freq-3010352-impl branch nijtmans added on 2011-03-27 14:09:33: Uploaded new patch against current trunk nijtmans added on 2011-03-27 14:09:08: File Added - 405554: tcloo.patch nijtmans added on 2011-03-27 14:06:28: File Deleted - 386560: nijtmans added on 2010-09-20 14:28:09: >Should it replace it, or is there something more subtle ? The line should be replaced, there is nothing more subtile than that. Thanks!, I'll see if i can create a new patch. ferrieux added on 2010-09-19 22:41:29: Hmm, minor patching issue, the following hunk fails on tclOO.decls, because there's already a line with " scspec EXTERN". Should it replace it, or is there something more subtle ? --- generic/tclOO.decls5 Mar 2010 15:32:16 -00001.7 +++ generic/tclOO.decls13 Sep 2010 21:18:11 -0000 @@ -8,6 +8,7 @@ interface tclOO hooks tclOOInt +scspec TCLOOAPI declare 0 generic { Tcl_Object Tcl_CopyObjectInstance(Tcl_Interp *interp, nijtmans added on 2010-09-14 04:21:01: re-generated patch against current HEAD nijtmans added on 2010-09-14 04:20:31: File Added - 386560: tcloo.patch nijtmans added on 2010-09-14 04:18:27: File Deleted - 375940: nijtmans added on 2010-09-13 22:11:08: Related to [Bugs #3064962] Suboptimal linkage of stubbed functions. Kevin, how is your opinion on this? nijtmans added on 2010-06-02 16:24:37: File Added - 375940: tcloo.patch |