Tcl Source Code

View Ticket
Login
Ticket UUID: 2949740
Title: Segfault when open fails with "b" (binary) flag specified
Type: Bug Version: obsolete: 8.5.8
Submitter: a_kovalenko Created on: 2010-02-11 14:56:41
Subsystem: 24. Channel Commands Assigned To: dkf
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2010-02-11 22:27:09
Resolution: Fixed Closed By: dkf
    Closed on: 2010-02-11 15:26:56
Description:
open "|something-nonexistent" rb
=> Segmentation fault

The cause is that Tcl_SetChannelOption is called to set up binary translation, _without_ checking for success, and when [open] fails, NULL channel is passed into this function.

A trivial patch fixing this (one of possible variants, not necessary of the best code style) is attached.
User Comments: dkf added on 2010-02-11 22:26:56:

allow_comments - 1

Was trivial to fix (and a silly error).

a_kovalenko added on 2010-02-11 21:56:41:

File Added - 362522: tcl-openrb-fail-segfault.patch

Attachments: