| Ticket UUID: | 2892871 | |||
| Title: | Autoconferry from the Autoconf Fairy | |||
| Type: | Patch | Version: | None | |
| Submitter: | stwo | Created on: | 2009-11-05 21:38:32 | |
| Subsystem: | 53. Configure and Build Tools | Assigned To: | stwo | |
| Priority: | 4 | Severity: | ||
| Status: | Closed | Last Modified: | 2009-11-25 21:34:23 | |
| Resolution: | Accepted | Closed By: | stwo | |
| Closed on: | 2009-11-25 14:34:23 | |||
| Description: |
1) In tcl.m4 the autoconf macro AC_STRUCT_TIMEZONE is used but its resultant defines HAVE_STRUCT_TM_TM_ZONE, HAVE_TM_ZONE and possibly HAVE_TZNAME are not referenced anywhere in Tcl or in Tk. I recommend it be removed since a) it's not being used, and b) it creates up to two unused defines which clutter the tclConfig.h file and the compile command line needlessly. 2) The autoconf macro AC_STRUCT_ST_BLKSIZE is obsoleted and creates two defines: HAVE_STRUCT_STAT_ST_BLKSIZE and the obsoleted HAVE_ST_BLKSIZE, cluttering the tclConfig.h file and the compile command line needlessly. I (and the autoconf docs) recommend it be changed to AC_CHECK_MEMBERS([struct stat.st_blksize]) which creates the single define HAVE_STRUCT_STAT_ST_BLKSIZE and to modify all code which checks for HAVE_ST_BLKSIZE to check for HAVE_STRUCT_STAT_ST_BLKSIZE instead. Patches are against HEAD of Nov 4/5. | |||
| User Comments: |
stwo added on 2009-11-25 21:34:23:
allow_comments - 1 stwo added on 2009-11-06 04:40:34: File Added - 349696: ac_cleanup1_tk.patch stwo added on 2009-11-06 04:38:35: File Added - 349695: ac_cleanup1_tcl.patch | |||
Home
Timeline
Branches
Tags
Tickets
Download
Wiki