Tcl Source Code

In [Tk Bug #2875562] Andres Garcia Garcia (fandom) added the following comment:

> But, could please check whether 'package require registry' works for you?
> In my case, pkgIndex.tcl doesn't get created for the extension while it is
> when compiling with shared libraries.

ok, but if it's a [load]able part of the
test suite, then at least we could do
away with the tcltest executable, and
its outdated "big wish" format.

allow_comments - 1

>package require]-able?
>bundled as a tcl/pkgs/subdir ?
>Installed?

Sure, that's all possible, but still I would answer NO
to all of those. Tcltest should take the role of an
internal package which sole purpose is for local
testing, so it is part of the test suite.

Anyway, closing now

perhaps not the place to continue the topic,
but if Tcltest is becoming [load]able, I'm
interested how far we can push that...

[package require]-able?

bundled as a tcl/pkgs/subdir ?

Installed?

Well, safe-10.1 and safe-10.4 fixed now, Everything should be fine.

Aha!  I didn't catch on to what you were doing.

[load]able Tcltest?  Very nice....

With the ability to build restored, we can
find the failing tests created by this change:

==== safe-10.1 testing statics loading FAILED
==== Contents of test case:

    set i [safe::interpCreate]
    list  [catch {interp eval $i {load {} Tcltest}} msg]  $msg  [safe::interpDelete $i];

---- Result was:
1 {can't read "msg": no such variable} {}
---- Result should have been (exact matching):
1 {can't use package in a safe interpreter: no Tcltest_SafeInit procedure} {}
==== safe-10.1 FAILED



==== safe-10.4 testing nested statics loading / -nestedloadok FAILED
==== Contents of test case:

    set i [safe::interpCreate -nestedloadok]
    list  [catch {interp eval $i {interp create x; load {} Tcltest x}} msg]  $msg  [safe::interpDelete $i];

---- Result was:
1 {can't read "msg": no such variable} {}
---- Result should have been (exact matching):
1 {can't use package in a safe interpreter: no Tcltest_SafeInit procedure} {}
==== safe-10.4 FAILED

Remark: The advantage of this change is that the Tcltest package now
contains all (binary) code needed to run the test suite. There is no need
to split it up in "procbodytest"/"objtest"/"threadtest" or whatever.

Yes, I forgot to update my files before synchronising, as a result unix/tclAppInit.c and win/tclAppInit.c are screwed up now.

Unfortunately, I'm behind a firewall now, which doesn't let me
check in the fix, but I attached the fix to this Issue. Please, someone
who can do it, fix it (trivially), otherwise I will do it tohight.

See attached patch.

Regards,
         Jan Nijtmans ;-(

File Added - 351618: tcl.patch

The unix/tcltest executable now fails to compile:

/home/dgp/cvs/tcl/unix/tclAppInit.c: In function ‘Tcl_AppInit’:
/home/dgp/cvs/tcl/unix/tclAppInit.c:126: error: ‘Tcltest_SafeInit’ undeclared (first use in this function)
/home/dgp/cvs/tcl/unix/tclAppInit.c:126: error: (Each undeclared identifier is reported only once
/home/dgp/cvs/tcl/unix/tclAppInit.c:126: error: for each function it appears in.)
make: *** [tclTestInit.o] Error 1

Fixed in HEAD

The same problem happens with dde.

Since I don't use the extension myself, I only noticed it when trying to compile an 8.6 TclKitLite

Confirmed. Probably a problem in Tcl 8.5 as well.