| Ticket UUID: | 2570363 | |||
| Title: | Tcltest evaluates $env(TCLTEST_OPTIONS) | |||
| Type: | Bug | Version: | obsolete: 8.6b1.1 | |
| Submitter: | sbron | Created on: | 2009-02-05 23:33:22 | |
| Subsystem: | 34. tcltest Package | Assigned To: | dgp | |
| Priority: | 8 | Severity: | ||
| Status: | Closed | Last Modified: | 2009-04-08 23:05:49 | |
| Resolution: | Fixed | Closed By: | dgp | |
| Closed on: | 2009-04-08 16:05:49 | |||
| Description: |
Tcltest evals $::env(TCLTEST_OPTIONS) in function ConfigureFromEnvironment. Externally provided data should be treated more carefully. | |||
| User Comments: |
dgp added on 2009-04-08 23:05:49:
allow_comments - 1 Fixes committed. dgp added on 2009-02-10 21:05:08:
The {*} fix should go into tcltest 2.3.1
The more careful [eval] should go into tcltest 2.2.10
nijtmans added on 2009-02-10 19:09:58: Agreed. However, wouldn't
if {[catch {Configure {*}$::env(TCLTEST_OPTIONS)} msg]} {
be simpler, more efficient and more readable than
if {[catch {eval [linsert $::env(TCLTEST_OPTIONS) 0 Configure]} msg]} {
?
Apart from that, there are serveral more suspicious eval's in
tcltest.tcl, that should be handled similar.
sbron added on 2009-02-06 06:33:23: File Added - 312239: tcltest.patch | |||
Attachments:
- tcltest.patch [download] added by sbron on 2009-02-06 06:33:23. [details]