Tcl Source Code

The attached tip609.diff contains an implementation for tip#609. The diff is against [e55cd6d5bf44bde46c0cbd4b127b29d82edd2d59].

Searching for TCL_QUEUE_MARK over the entire AndroWish source tree gives few hits and in Tk only. The usage is not bound to multiple threads. Thus, I believe, it is not necessary to have TCL_QUEUE_ALERT_IF_EMPTY for the queue mark operation.

TIP is adapted to implementation now. Just one question remains: Is the TCL_QUEUE_ALERT_IF_EMPTY flag supposed to work together with TCL_QUEUE_MARK too? If yes, then the implementation should be adapted to allow that. If no, that should be reflected in the TIP and the documentation. That's my only remaining remark.

Thanks!

Thanks for making it into a new branch. The solution with a single TCL_QUEUE_ALERT_IF_EMPTY flag is equivalent but please Jan or Harald change the TIP's text and example accordingly. And I think that an additional preprocessor symbol is still needed in order to be able to allow for conditional compilation for older cores without that feature (future/backward/forward/past compatibility).

Thanks. My only remark is that instead of 2 new flags `TCL_QUEUE_HEAD_ALERT_IF_EMPTY`/`TCL_QUEUE_TAIL_ALERT_IF_EMPTY` I would prefer a single new flag TCL_QUEUE_ALERT_IF_EMPTY which can be combined with the other flags. See: [c7572c6dc42e6380]. This way we don't need the clumsy `Tcl_QueuePositionEx` any more. Please review my proposed changes!