Tcl Source Code

View Ticket
Login
Ticket UUID: 22ab2ae64ab2dd813719a985a6f125631ab1ba74
Title: Build with minizip broken
Type: Bug Version: 8.7a6
Submitter: anonymous Created on: 2022-09-19 17:19:06
Subsystem: 53. Configuration and Build Tools Assigned To: jan.nijtmans
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2022-09-23 15:18:49
Resolution: Fixed Closed By: anonymous
    Closed on: 2022-09-23 15:18:49
Description:
I build Tcl in a container.  The "zip" utility is not installed,
so the build uses the bundled "minizip".  The latest version of
minizip mis-handles symlinks, so in the zipfs that is attached to
the shared library the contents of subdirectories is missing.
This means that e.g. "package require tcltest" fails.

Using "stat" instead of "lstat" in tinydir.h seems to fix the
problem.
User Comments: anonymous (claiming to be [email protected]) added on 2022-09-23 15:18:49:
Thanks for merging the patch.

> Shouldn't this be reported upstream?
> https://github.com/cxong/tinydir/

In general, I agree.  I was not aware that tinydir was a project
independent of minizip.  That might make an upstream solution a little
bit more complex.

jan.nijtmans added on 2022-09-22 12:42:56:

Fixed now in all branches.

Thanks!


jan.nijtmans added on 2022-09-20 21:02:09:

Well, the "minizip" included with Tcl is modified, this - exactly - is the danger doing that.

Shouldn't this be reported upstream? https://github.com/cxong/tinydir/


anonymous added on 2022-09-19 17:22:52:
I am assuming that the same issue occurs on all branches that
have the latest minizip.

Attachments: