Tcl Source Code

View Ticket
Login
Ticket UUID: 219220
Title: 64bit enablement broken
Type: Bug Version: final: 8.2.3
Submitter: nobody Created on: 2000-10-26 05:03:46
Subsystem: 53. Configuration and Build Tools Assigned To: mdejong
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2002-07-24 00:34:37
Resolution: Accepted Closed By: mdejong
    Closed on: 2002-07-23 17:34:37
Description:
OriginalBugID: 4015 Bug
Version: 8.2.3
SubmitDate: '2000-01-13'
LastModified: '2000-04-03'
Severity: SER
Status: Assigned
Submitter: techsupp
ChangedBy: hobbs
OS: IRIX
Machine: SGI/ORIGIN 2000
FixedDate: '2000-10-25'
ClosedDate: '2000-10-25'


Name: george r. goffe

Comments:
I attempted to put this change into tk8.2.3 but there is no aclocal.m4 distributed apparently. I copied the tcl aclocal.m4 file but that didn't generate the right configure script.

Please call me for any clarification(s) needed, "we" have a 64bit application that "wants" to use tcl/tk in 64bit mode. There were also a lot of compiler warnings about (int) not holding all the pointer. I have a file with these messages in it if you'd like to see it.

Please let me know what kind of action(s) you might be taking with this report.

Thanks,

George...

ReproducibleScript:
./configure ... --enable-64bit ...

ObservedBehavior:
It would be nice to have 64bit code generated for tcl and tk.

I have a fix from a collegue (James Jones) that seems to work for tcl but apparently(?) the aclocal.m4 file for tk is not distributed? 64bit enablement is broken for both tcl and tk.

DesiredBehavior:
see above

Patch:
diff -c aclocal.m4.dist aclocal.m4
*** aclocal.m4.dist     Thu Jan 13 15:22:11 2000
--- aclocal.m4  Thu Jan 13 15:24:02 2000
***************
*** 676,681 ****
--- 676,692 ----
            DL_LIBS=""
            LDFLAGS=""
            LD_SEARCH_FLAGS='-Wl,-rpath,${LIB_RUNTIME_DIR}'
+             do64bit_ok=no
+             if test "$do64bit" = "yes" ; then
+                if test "$CC" != "gcc" ; then
+                   do64bit_ok=yes
+                   SHLIB_LD="ld -64 -shared -rdata_shared"
+                   EXTRA_CFLAGS="-64"
+                   LDFLAGS="-64"
+                else 
+                   AC_MSG_WARN(64bit mode not supported by gcc...)
+                fi
+             fi
            ;;
        Linux*)
            SHLIB_CFLAGS="-fPIC"

PatchFiles:
tcl8.2.3/unix/aclocal.m4



The user noted this "better" fix:

*** aclocal.m4.distTue Dec 14 19:59:18 1999
--- aclocal.m4Thu Jan 13 15:58:41 2000
***************
*** 643,649 ****
      LD_SEARCH_FLAGS='-L${LIB_RUNTIME_DIR}'
      SHARED_LIB_SUFFIX='${VERSION}\$\{DBGX\}.a'
      ;;
! IRIX-5.*|IRIX-6.*|IRIX64-6.5*)
      SHLIB_CFLAGS=""
      SHLIB_LD="ld -n32 -shared -rdata_shared"
      SHLIB_LD_LIBS='${LIBS}'
--- 643,649 ----
      LD_SEARCH_FLAGS='-L${LIB_RUNTIME_DIR}'
      SHARED_LIB_SUFFIX='${VERSION}\$\{DBGX\}.a'
      ;;
! IRIX-5.*|IRIX-6.*)
      SHLIB_CFLAGS=""
      SHLIB_LD="ld -n32 -shared -rdata_shared"
      SHLIB_LD_LIBS='${LIBS}'
***************
*** 676,681 ****
--- 676,692 ----
      DL_LIBS=""
      LDFLAGS=""
      LD_SEARCH_FLAGS='-Wl,-rpath,${LIB_RUNTIME_DIR}'
+             do64bit_ok=no
+             if test "$do64bit" = "yes" ; then
+                if test "$CC" != "gcc" ; then
+                   do64bit_ok=yes
+                   SHLIB_LD="ld -64 -shared -rdata_shared"
+                   EXTRA_CFLAGS="-64"
+                   LDFLAGS="-64"
+                else 
+                   AC_MSG_WARN(64bit mode not supported by gcc...)
+                fi
+             fi
      ;;
  Linux*)
      SHLIB_CFLAGS="-fPIC"

However this seems to change the behavior for all of IRIX64-6.5*
which may note be correct. 
-- 02/05/2000 hobbs
User Comments: mdejong added on 2002-07-24 00:34:37:
Logged In: YES 
user_id=90858

Added the patch to CVS. It has not been tested but
it seems ok.

mdejong added on 2002-04-19 05:35:14:

File Added - 21479: 64bit_irix.patch

Logged In: YES 
user_id=90858

I have created a patch for the current CVS. Could someone
with access to a 64 bit IRIX system give this patch
a test drive?

dkf added on 2001-08-29 20:45:34:
Logged In: YES 
user_id=79902

That looks like the right sort of think for IRIX64, and the
restriction that it does not work with GCC (or didn't the
last time I looked) is spot-on.  However, all that autoconf
stuff has been rearranged, so I'm assigning to Mo...

andreas_kupries added on 2001-08-24 05:03:45:
Logged In: YES 
user_id=75003

Given to donal as he seems to have 64bit machines.
Else give it to Mo.

Attachments: