Tcl Source Code

I found an issue while using TclBlend in Tcl 8.5, and the attached script demonstrates it.  Basically, the conversion of an internal representation from list to dict is special cased to keep the representations of the elements, while the conversion from dict to list passes through a string-only representation.  This appears even in code that does not explicitly use dict because the array get and set have changed to use dict now.

TclBlend uses a special internal representation to hold references to Java objects, and if the internal representation is lost then the underlying object might get freed.  This violates the "everything is a string" but in the past it's been sufficient to just make sure that the Tcl script itself was careful with the references it obtained.  If the Tcl core changes internal representations beyond what is needed then an extension like this really does not seem to have much of a chance of working.

Logged In: YES 
user_id=79902
Originator: NO

Backported to 8.5 branch. Patch actually used takes some shortcuts that your suggestion didn't (since I know what the pre- and post-conditions on the core dict API functions are) but is otherwise the same. Thanks.

Logged In: YES 
user_id=79902
Originator: NO

Fixed on HEAD. Backport needed.

Logged In: YES 
user_id=79902
Originator: NO

While Tcl's never guaranteed anything about representations, it would be nice to not lose them.

File Added - 283441: tcllist.patch

Logged In: YES 
user_id=1055638
Originator: YES

It appears my mistake was not always passing at least 1 to NewListIntRep.  I've fixed that.  The reason it crashed was that the core is calling SetListFromAny with a null interp from several places.  I had copied the Tcl_SetObjResult call when NewListIntRep fails from the "from string rep" branch in the same routine, so it hadn't occurred to me it wasn't safe.
File Added: tcllist.patch

File Deleted - 283352:

Logged In: YES 
user_id=1055638
Originator: YES

OK there is definitely something wrong with that patch because I got a crash in clock format with it applied.  I'll look at it some more, but hopefully it's more obvious to someone here.

File Added - 283352: tcllist.patch

Logged In: YES 
user_id=1055638
Originator: YES

The attached patch seems to work for me, but I'd appreciate it if someone more familiar with this code could check it out.
File Added: tcllist.patch

File Added - 283351: jtest.tcl