| Ticket UUID: | 1a3fa1232e306a447f480f76a9c83d1bdbf358d2 | |||
| Title: | test cmdMZ-6.5 not testing all code paths | |||
| Type: | Bug | Version: | trunk | |
| Submitter: | emiliano | Created on: | 2019-03-30 18:16:22 | |
| Subsystem: | - New Builtin Commands | Assigned To: | nobody | |
| Priority: | 5 Medium | Severity: | Minor | |
| Status: | Closed | Last Modified: | 2019-04-01 13:55:35 | |
| Resolution: | Fixed | Closed By: | sebres | |
| Closed on: | 2019-04-01 13:55:35 | |||
| Description: |
testing trunk on a slow machine shows a failing test cmdMZ-6.5
cmdMZ.test
==== cmdMZ-6.5 Tcl_TimeRateObjCmd: result format and one iteration FAILED
==== Contents of test case:
regexp {^\d+.\d+ \ws/# 1 # \d+ #/sec \d+.\d+ nett-ms$} [timerate {} 0]
---- Result was:
0
---- Result should have been (exact matching):
1
==== cmdMZ-6.5 FAILED
code shows that the result of [timerate] is a list and the fourth element can be either an integer or a float with 1, 2 or 3 decimals (file generic/tclCmdMZ.c, lines 4424-4438) but only the integer path is tested.
The obvious solution is to test for those possibilities as well.
No other code paths were tested/reviewed.
| |||
| User Comments: |
sebres added on 2019-04-01 13:55:35:
Fixed in [c925d4759d96961f]. Thx! | |||
Attachments:
- timerate.diff [download] added by emiliano on 2019-03-30 18:17:45. [details]