Tcl Source Code

tclOO.decls uses commands that tools/genStubs.tcl does not understand, breaking 'make genstubs'.

oo/tools/genStubs.tcl is not the standard genStubs.tcl, it appears to be derived from ttkGenStubs.tcl, and does not have any of the recent modifications that were made to tcl/tools/genStubs.tcl e.g. for static const stubs tables [patch 1938497].

Either the tclOO specific genStubs.tcl needs to be added to tcl/tools or (preferably) the extra functionality tclOO requires needs to be added to tcl/tools/genStubs.tcl

Logged In: YES 
user_id=79902
Originator: NO

TclOO 0.5 uses the Tcl scheme.

Logged In: YES 
user_id=90580
Originator: YES

committed to HEAD, leaving open for TclOO

Logged In: YES 
user_id=79902
Originator: NO

Sounds fair enough to me. I'm planning to do the same to TclOO④8.5

Logged In: YES 
user_id=90580
Originator: YES

if there are no objections to the tclOOhooks.diff patch, I'll commit later today

File Added - 279740: tclOOhooks.diff

Logged In: YES 
user_id=90580
Originator: YES

concretely, the attached patch replaces use of struct TclOOStubAPI by the pointer to tclOOIntStubs in the main table hooks
File Added: tclOOhooks.diff

Logged In: YES 
user_id=90580
Originator: YES

re hooks: AFAIU that's just a way to hang additional stubs tables off the main table, could be used for tclOO as well, obviating the need for struct TclOOStubAPI...

Logged In: YES 
user_id=90580
Originator: YES

great!
no worries about merging my fixes to the generated files, I can do that, just commit what make genstubs produces...

Logged In: YES 
user_id=79902
Originator: NO

Sorted. Problems were two commands that were not really used, 'common/generic' in the main declarations, the hooks stuff (which I still don't really understand) and the fact that each interface needs to be generated separately. (Someone ought to do some kind of interlock there to prevent this sort of thing happening again...)

Now I've just got to undo the damage caused by your jumping the gun with "fixes".

Logged In: YES 
user_id=79902
Originator: NO

Grrr.

It was indeed written using the genstubs used in Tile, though the extra features in tclOO.decls from that system were actually not used in any meaningful way. But it seems that stubs generation is currently completely broken; tclOODecls.h is (effectively) empty following obvious changes, and tclOOStubInit.c is full of irrelevant rubbish (and yet nothing required)! Don't know why yet.