| Ticket UUID: | 1942222 | |||
| Title: | useless call to endgrent()/endpwent() | |||
| Type: | Bug | Version: | obsolete: 8.5.2 | |
| Submitter: | karllim | Created on: | 2008-04-14 16:22:30 | |
| Subsystem: | 37. File System | Assigned To: | dkf | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2009-08-02 19:16:19 | |
| Resolution: | Fixed | Closed By: | dkf | |
| Closed on: | 2009-08-02 12:16:19 | |||
| Description: |
in unix/tclUnixFCmd.c, GetGroupAttribute() and GetOwnerAttribute() make calls to non-wrapped POSIX calls endpwent() and endgrent(). These two calls are marked to be avoided by the Open Group http://www.opengroup.org/onlinepubs/009695399/functions/getgrent.html Moreover, the actual calls are useless since TclpGetPwUid() and TclpGetGrUid() do use the newer grgetpw() and grgetgid(). Solution : remove the calls. | |||
| User Comments: |
dkf added on 2009-08-02 19:16:19:
allow_comments - 1 dkf added on 2009-08-02 19:15:24: Backported to 8.5 branch dkf added on 2009-08-02 19:08:29: Looks like those are hangovers from when we did use getpwent() and getgrent(), and serve no purpose now. Fixed on HEAD. dkf added on 2009-08-02 18:44:14: IP - Comment Removed: 77.97.136.76 karllim added on 2008-04-14 23:28:49: File Added - 274491: tcl_endgrpwent_20080414.diff Logged In: YES user_id=143750 Originator: YES File Added: tcl_endgrpwent_20080414.diff karllim added on 2008-04-14 23:28:29: File Deleted - 274488: karllim added on 2008-04-14 23:22:31: File Added - 274488: tcl_endgrpwent_20080414.diff | |||
Attachments:
- tcl_endgrpwent_20080414.diff [download] added by karllim on 2008-04-14 23:28:49. [details]