Tcl Source Code

The Open Group defines gettimeofday() with the following prototype :
 int gettimeofday(struct timeval *restrict tp, void *restrict tzp);

However, TCL uses a struct timezone as the second argument, where it is described that anything else than a NULL tzp argument is undefined.

Solution : pass NULL.

See Bug 3530533 for problems this change
causes on an IRIX64 6.5 system.

Logged In: YES 
user_id=99768
Originator: NO

Passing a NULL 'tzp' argument to gettimeofday is verified as harmless (indeed, preferred) on Solaris, HP-UX, glibc, the various BSD's (and hence MacOSX), and AIX.  Doesn't seem to be any reason not to commit.

Logged In: YES 
user_id=99768
Originator: NO

Agreed that second arg to gettimeofday should be NULL on modern Unixes.  There's an open question regarding whether we support any environments where a non-NULL second arg is still required.  (It seems unlikely, since Posix says that the second arg SHOULD be NULL.)

Change is trivial, and I'll make it when I've done a bit more research.

File Added - 274484: tcl_timezone_20080414.diff