Tcl Source Code

View Ticket
Login
Ticket UUID: 1835061
Title: Fail to build and test thread on Win32/MSVC
Type: Bug Version: obsolete: 8.5b2
Submitter: twylite Created on: 2007-11-20 10:41:29
Subsystem: 80. Thread Package Assigned To: vasiljevic
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2009-05-05 05:47:48
Resolution: Fixed Closed By: patthoyts
    Closed on: 2009-05-04 22:47:48
Description:
Problems in the makefile.vc and test files prevent the thread package from being successfully built on Win32 using MSVC6 or MSVC8.

(1) The link flag -nodefaultlib:msvcrt has been added in the case of non-static builds (which must link against MSVCRT).  This was probably added in error because Thread failed to link against a Tcl DLL which was compiled with different library flags (-MT instead of -MD).  This flag must be removed.

(2) tests/all.tcl doesn't correctly load the Thread DLL (specified via -loadfile by the makefile.vc), so tests can't run at all.

(3) tests/thread.test attempts to resolve $::tcl_PatchLevel on non-unix platforms (note capatalisation error: should be $::tcl_patchLevel).

The attached patch fixes all these errors and bumps the package version to 2.6.6 (in configure.in and pkg.vc).  The maintainer will need to reconfigure.
User Comments: patthoyts added on 2009-05-05 05:47:48:
Update the msvc build files for the more recent versions that support the newer compilers and platforms. All tests pass ok on 32 and 64 bit versions.

twylite added on 2007-11-20 18:12:48:
Logged In: YES 
user_id=91629
Originator: YES

On this patch is applied the following bugs/patches can also be closed:

[ 1716587 ] Thread tests can't run (bad args from makefile)
[ 1689375 ] Update VC makefile for Threads (Fix for bug 1643367)
[ 1643367 ] Thread extension cannot compile with VC8

twylite added on 2007-11-20 17:41:30:

File Added - 255103: tcl-thread-build-20071120.patch

Attachments: