| Ticket UUID: | 1830184 | |||
| Title: | Tcl_ResetResult shortcut | |||
| Type: | Patch | Version: | None | |
| Submitter: | msofer | Created on: | 2007-11-12 03:37:12 | |
| Subsystem: | 45. Parsing and Eval | Assigned To: | dgp | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2007-11-27 10:20:06 | |
| Resolution: | None | Closed By: | sf-robot | |
| Closed on: | 2007-11-27 03:20:06 | |||
| Description: |
Attached patch (committed, big perf improvement in command call overhead) has ChangeLog entry: "New macro TclResetResult, new iPtr flag bit INTERP_RESULT_UNCLEAN: shortcut for Tcl_ResetResult for the "normal" case: TCL_OK, no return options, no errorCode nor errorInfo, return at normal level." When INTERP_RESULT_UNCLEAN is set there is no shortcut, the code path is as before. Not sure if the bit is set too often. Please review. | |||
| User Comments: |
sf-robot added on 2007-11-27 10:20:06:
Logged In: YES user_id=1312539 Originator: NO This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). msofer added on 2007-11-13 05:09:35: Logged In: YES user_id=148712 Originator: YES THIS PATCH WAS REVERTED: initial (mis)measurements overstated the perfomance wins, which turn out to be tiny. Not worth the complication. msofer added on 2007-11-12 10:37:14: File Added - 253878: result.diff | |||
Attachments:
- result.diff [download] added by msofer on 2007-11-12 10:37:12. [details]