| Ticket UUID: | 1754128 | |||
| Title: | allow use of 'inline' in Tcl sources | |||
| Type: | Patch | Version: | None | |
| Submitter: | kennykb | Created on: | 2007-07-14 22:23:16 | |
| Subsystem: | 53. Configure and Build Tools | Assigned To: | msofer | |
| Priority: | 7 High | Severity: | ||
| Status: | Closed | Last Modified: | 2007-07-31 21:05:49 | |
| Resolution: | Accepted | Closed By: | msofer | |
| Closed on: | 2007-07-31 14:05:49 | |||
| Description: |
Miguel Sofer, as part of the 'Var reform' patch,
has asked for the ability to use 'inline' functions
in tclVar.c
This turns out to be easy. AC_C_INLINE in the
'configure.in' files should, if the compiler doesn't
support 'inline', define a macro of that name that
expands to '__inline__', '__inline', or nothing,
as appropriate. ('Nothing' will have the effect of
making the 'static inline' function fall back on being
an ordinary static function.)
I don't see any compelling reason not to let him have
his inline, do you?
| |||
| User Comments: |
dkf added on 2007-07-24 04:09:28:
Logged In: YES user_id=79902 Originator: NO No objections provided this is only used for 'static' functions. But make sure that no sniff of it goes anywhere near tcl.m4; there's enough stuff in there that's got cargo-cult-ed to goodness knows how many TEA extensions which really doesn't need to be there, and it's tricky (!) to make it work with stubs as it tends to bind the API version too tightly into the callers. (None of that matters if it is used sensibly, of course.) kennykb added on 2007-07-15 05:40:01: File Deleted - 237028: File Added - 237029: inline.patch Logged In: YES user_id=99768 Originator: YES pdated patch - missed 'makefile.vc' on the first go. File Added: inline.patch kennykb added on 2007-07-15 05:23:17: File Added - 237028: inline.patch | |||
Attachments:
- inline.patch [download] added by kennykb on 2007-07-15 05:40:01. [details]