| Ticket UUID: | 1749987 | |||
| Title: | Tcl_ParseExpr does not return error type or location | |||
| Type: | Bug | Version: | obsolete: 8.5a7 | |
| Submitter: | kennykb | Created on: | 2007-07-08 18:59:19 | |
| Subsystem: | 45. Parsing and Eval | Assigned To: | dgp | |
| Priority: | 9 Immediate | Severity: | ||
| Status: | Closed | Last Modified: | 2007-07-09 21:50:09 | |
| Resolution: | Fixed | Closed By: | dgp | |
| Closed on: | 2007-07-09 14:50:09 | |||
| Description: |
Tcl_ParseExpr, after the recent refactoring, fails to return parsePtr->errorType and parsePtr->term reporting the location and type of the error. This behaviour causes a panic in the test suite of the 'tclparser' module of TclPro. While 'tclparser' should be more forgiving - panicking in this case is surely not right (and I'm fixing it) - we should still restore the documented results. The attached patch appears to make TclPro's test suite happy. I haven't developed test cases for Tcl's own test suite yet, partly because the relevant commands in tclTest.c don't appear to report parse.errorType (or indeed, report parse.term in all cases). | |||
| User Comments: |
dgp added on 2007-07-09 21:50:09:
File Added - 236264: 1749987.patch Logged In: YES user_id=80530 Originator: NO updated patch gets another missing parent code. committing.... File Added: 1749987.patch dgp added on 2007-07-09 19:37:17: Logged In: YES user_id=80530 Originator: NO Thanks for the alert. This is the TODO on line 1238 of tclCompExpr.c. Now that I know something cares I'll TODO it sooner. kennykb added on 2007-07-09 01:59:19: File Added - 236157: compExpr.patch | |||
Home
Timeline
Branches
Tags
Tickets
Download
Wiki