Tcl Source Code

Make changes so parser
generates same tokens
for

{*}{set a 1}

as it does for

set a 1

Logged In: YES 
user_id=80530
Originator: YES

committed.

Logged In: YES 
user_id=75003
Originator: NO

Review: Looks good after a single scan through it. I am assuming that it compiles and passes the testsuite ... +1 for commit. It is wonderful to see all the special token expansions done for #280 disappear and everything done more generally.

Logged In: YES 
user_id=75003
Originator: NO

Regarding debugging routines ... I have no big desire for them. Especially if testparser can do the same thing. Re define's I was not aware that they were dups, removal for such is definitely ok.

File Added - 231128: 1725186-3.patch

Logged In: YES 
user_id=80530
Originator: YES


next (final?) version of the patch
adds comments to the parser additions
to explain what's going on a bit better.


File Added: 1725186-3.patch

File Added - 231122: 1725186-2.patch

Logged In: YES 
user_id=80530
Originator: YES

updated patch adds simplification
of sections that no longer have
to deal with expanded literals
in the token stream.

File Added: 1725186-2.patch

Logged In: YES 
user_id=80530
Originator: YES


yes, those appeared to be some debugging
tools that got mistakenly committed.
Duplicated #define's were certainly
a mistake, and the routines didn't appear
to me to do any more than the existing
[testparser] command can do.

If they're desired for some reason, it's
easy enough to restore them.

Logged In: YES 
user_id=75003
Originator: NO

Quick glance. Looks ok as far as I understand the token structures. Only wondering if the removal of the 'PrintToken' functions is intentional.

File Added - 230994: 1725186.patch

Logged In: YES 
user_id=80530
Originator: YES


first patch attempt just adds the
capability to the parser.

surprisingly few (one!) parse.test
tests are unhappy about this change.
File Added: 1725186.patch