Tcl Source Code

(A) makefile.vc was updated to the 8.5 build system (ChangeLog 2007/05/03); it calls the test scripts in a new manner (using a -loadfile argument).  tests/all.tcl has not been updated to support this, and as a result the 
Thread26.dll is never loaded, and the tests cannot run.

(B) tests/thread.test references tcl_PatchLevel which causes an exception.  Should be tcl_patchLevel

Patch for these problems and bug [1716582] (Build broken for OPTS=symbols,unchecked) is attached.

Note: the patch partially reverts the calling of tests\all.tcl in the Makefile.  If you don't do this (and use the -loadfile argument that is has been changed to) then as far as I know you will not be able to build the Threads extension against Tcl 8.4.  That would be a Bad Thing (TM).

Notes:
(1) I haven't confirmed that the Thread extension DOES build against 8.4 with this patch (or without it)

(2) The upgrade referred to in (A) should have fixed [1643367] (Thread extension cannot compile with VC8), but I haven't tested that either.

Build of 32-bit binaries from thread branch thread-2-7-branch and tcl tag core-8-5-12 (both updated today), using MSVC10, testing on Windows 7 64-bit: all tests run successfully.

Same thread branch builds and tests successfully with tcl trunk.

Logged In: YES 
user_id=95086
Originator: NO

You got me! 

I normally do not own a PC with Windows. Therefore the Windows port
will always lag behind. I do not know how to iprove that. What about
adding yourself to the project and helping me out to keep that Windows
related code up to date?

Cheers
Zoran

File Added - 228661: thread-20070510.patch