| Ticket UUID: | 1669420 | |||
| Title: | [join] refactor | |||
| Type: | RFE | Version: | None | |
| Submitter: | dgp | Created on: | 2007-02-26 20:02:23 | |
| Subsystem: | 17. Commands I-L | Assigned To: | dgp | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2007-03-02 22:12:31 | |
| Resolution: | Accepted | Closed By: | dgp | |
| Closed on: | 2007-03-02 15:12:31 | |||
| Description: |
Attached patch is a rewrite of the [join] command. It replaces the old implementation, which explicitly generates and copies string reps, with a new implementation that simply calls Tcl_AppendObjToObj() and does whatever that does. This change means that [join] will receive whatever special case append efficiencies are built into Tcl_AppendObjToObj() both now, and going on into the future (where we might imagine, say, ByteArrays getting some attention). | |||
| User Comments: |
dgp added on 2007-03-02 22:12:31:
Logged In: YES user_id=80530 Originator: YES committed for 8.5a6 dkf added on 2007-02-27 22:19:27: Logged In: YES user_id=79902 Originator: NO The use of Tcl_AppendObjToObj instead of Tcl_AppendToObj seems reasonable. dgp added on 2007-02-27 03:02:24: File Added - 217882: join.patch | |||
Attachments:
- join.patch [download] added by dgp on 2007-02-27 03:02:23. [details]