Ticket UUID: | 1597389 | |||
Title: | --enable-64bit support for Linux | |||
Type: | Patch | Version: | None | |
Submitter: | das | Created on: | 2006-11-16 00:27:29 | |
Subsystem: | 52. Portability Support | Assigned To: | das | |
Priority: | 6 | Severity: | ||
Status: | Closed | Last Modified: | 2006-11-26 13:06:55 | |
Resolution: | Fixed | Closed By: | das | |
Closed on: | 2006-11-26 06:06:55 | |||
Description: |
configure needs --enable-64bit support on Linux, as certain platforms, such as the SF CF host openpower-linux1 (Power5 SUSE Linux) are 64-bit capable but compile for 32-bit by default. According to http://gcc.fyxm.net/summit/2003/Porting%20to%2064%20bit.pdf all that is required for recent 64-bit Linux with biarch compiler is to add - m64 to the gcc options for compiling and linking. The attached patch to tcl.m4 checks that linking with -m64 succeeds and adds that flag to CFLAGS. SHLIB_LD is changed to take account of CFLAGS & LDFLAGS (configure tests that this works, and we link executables in this way already so that should not cause any issues). This does the right thing on the openpower-linux1 host and leads to a 64-bit build that passes the testsuite. I've verified that passing --enable-64bit does no harm on the amd64- linux1 SF CF host (AMD64 - Fedora Linux), a 64-bit platform that compiles for 64-bit by default, in fact it avoids a confusing configure warning that 64-bit support is disabled (Bug 1230558) and marks the build as 64-bit in the TIP59 config info. | |||
User Comments: |
das added on 2006-11-26 13:06:55:
Logged In: YES user_id=90580 Originator: YES tested further with no problems don't see how this change could do any harm, so committed to HEAD, core-8-4-branch and tclconfig. das added on 2006-11-16 07:28:22: Logged In: YES user_id=90580 Originator: YES not sure who the best maintainer to review this is? Jeff? das added on 2006-11-16 07:27:29: File Added - 203030: linux-enable-64bit.diff |
Attachments:
- linux-enable-64bit.diff [download] added by das on 2006-11-16 07:27:29. [details]