Tcl Source Code

Just ran a "nmake test" of the just released
8.5a5 build on XP using VS6. The compiler gave some
warnings which look harmless enough (but you
might be interested):

eg.
        cl -nologo -c  -QI0f -D 
_CRT_SECURE_NO_DEPRECATE -D _CRT_NONSTDC_NO_DEPRECATE -
Fp.
\Release\tcl_Dynamic\ -W3 -O2  -Ot -Oi -Op -fp:strict -
Gs -GS -GL -YX -MD -I"..\win" -I"..
\generic" -I"..\libtommath"  -
DTCL_PIPE_DLL=\"tclpip.dll\" -DTCL_TOMMATH  -
DMP_PREC=4 -DTC
L_CFGVAL_ENCODING=\"cp1252\" -DTCL_CFG_OPTIMIZED -
Fo.\Release\tcl_Dynamic\tclTest.obj ..\g
eneric\tclTest.c
Command line warning D4002 : ignoring unknown option '-
fp:strict'
Command line warning D4002 : ignoring unknown option '-
GS'
Command line warning D4002 : ignoring unknown option '-
GL'

... and the linker also:

        link -nologo -machine:IX86 -ltcg -release -
opt:ref -opt:icf,3 -opt:nowin98 -subsys
tem:console -out:.\Release\cat32.exe -
stack:16384 .\Release\tcl_Dynamic\cat.obj  kernel32.
lib user32.lib
LINK : warning LNK4044: unrecognized option "ltcg"; 
ignored


Here are the results of the tests that failed (all
in fCmd):

==== fCmd-28.9 file link: success with file FAILED
==== Contents of test case:

    cd [temporaryDirectory]
    file delete -force abc.link
    set res [list [catch {file link abc.link abc.file} 
msg] $msg]
    cd [workingDirectory]
    set res

---- Result was:
0 D:/afredd/src/tcl/tcl8.5a5rc1-
src.tar/tcl8.5a5/win/abc.file
---- Result should have been (exact matching):
0 abc.file
==== fCmd-28.9 FAILED



==== fCmd-28.9.1 file link: success with file FAILED
==== Contents of test case:

    cd [temporaryDirectory]
    file delete -force abc.link
    set res {}
    file stat abc.file arr ; lappend res $arr(nlink)
    lappend res [catch {file link abc.link abc.file} 
msg] $msg
    file stat abc.file arr ; lappend res $arr(nlink)
    cd [workingDirectory]
    set res

---- Result was:
1 0 D:/afredd/src/tcl/tcl8.5a5rc1-
src.tar/tcl8.5a5/win/abc.file 2
---- Result should have been (exact matching):
1 0 abc.file 2
==== fCmd-28.9.1 FAILED



==== fCmd-28.11 file link: success with directory 
FAILED
==== Contents of test case:

    cd [temporaryDirectory]
    file delete -force abc.link
    set res [list [catch {file link abc.link abc.dir} 
msg] $msg]
    cd [workingDirectory]
    set res

---- Result was:
0 D:/afredd/src/tcl/tcl8.5a5rc1-
src.tar/tcl8.5a5/win/abc.dir
---- Result should have been (exact matching):
0 abc.dir
==== fCmd-28.11 FAILED



==== fCmd-28.19 file link: relative paths FAILED
==== Contents of test case:

    cd [temporaryDirectory]
    file mkdir d1/d2/d3
    set res [list [catch {file link d1/l2 d1/d2} err] 
$err]
    lappend res [catch {file delete -force d1} err] 
$err

---- Result was:
0 D:/afredd/src/tcl/tcl8.5a5rc1-
src.tar/tcl8.5a5/win/d1/d2 0 {}
---- Result should have been (exact matching):
0 d1/d2 0 {}
==== fCmd-28.19 FAILED

Logged In: YES 
user_id=1312539

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

Logged In: YES 
user_id=19214

Applied afredd-supplied patches, with thanks.

File Added - 198002: tclWinFile.c189-patch

Logged In: YES 
user_id=1386588


Attached patch passes tests.

Needed to avoid reassiging toPtr, as it used as
the return value.

Logged In: YES 
user_id=1386588


The change 1.89 of tclWinFile.c does _not_ appear
to fix the problem. I still get the same 4 fails:
fCmd-28.9, fCmd-28.9.1, fCmd-28.11 & fCmd-28.19.

Logged In: YES 
user_id=19214

I misinterpreted the windows [file link] code while trying
to protect against a potential NULL return error.

I've reworked the fix.  Should work now.  Please test (I
don't have Windows.)

Logged In: YES 
user_id=80530


Best guess is that the
2006-08-29 commit from
coldstore is to blame.
Please review.

Logged In: YES 
user_id=80530

ok, so sometime since
8.5a4, [file link] on
Windows has started returning
only absolute paths.  Gotta 
locate the source of that
regression.

Logged In: YES 
user_id=1386588

>> Are any of these failures also seen in the 8.4.14rc1?
>
>All test passed for me with that build.

fwiw - just tried 8.5a4, and this too passed all tests.

Logged In: YES 
user_id=1386588


> Are any of these failures also seen in the 8.4.14rc1?

All test passed for me with that build.

NB. There is no fCmd-28.9.1 or fCmd-28.19 in
8.4.14's fCmd.test.

Logged In: YES 
user_id=80530


Are any of these failures also
seen in the 8.4.14rc1 ?