Tcl Source Code

View Ticket
Login
Ticket UUID: 1536142
Title: cwdPathPtr incomplete finalization
Type: Bug Version: obsolete: 8.4.14
Submitter: dgp Created on: 2006-08-07 16:42:35
Subsystem: 37. File System Assigned To: dgp
Priority: 9 Immediate Severity:
Status: Closed Last Modified: 2006-08-21 22:03:58
Resolution: Fixed Closed By: dgp
    Closed on: 2006-08-21 15:03:58
Description:
When a thread is finalized,
the routine FsThrExirProc() gets
called to finalize
the ThreadSpecificData of
tclIOUtil.c.

This routine decrements a
refcount on the master copy
of cwdPathPtr, but fails to
NULL out its cached reference.
This permits attempts to use
that invalid pointer which
leads to panics.

Here's a patch to complete
the finalization.

The same patch ought to 
apply to the HEAD which
appears to suffer from
the same bug.
User Comments: dgp added on 2006-08-21 22:03:57:
Logged In: YES 
user_id=80530


patch committed to both active branches

nobody added on 2006-08-18 05:02:17:
Logged In: NO 

Thanks for the push!

Indeed the patch looks entirely correct, and the right way
of doing things, so please do commit.

Vince.

dgp added on 2006-08-18 03:10:46:
Logged In: YES 
user_id=80530


had a chance to review this yet?

dgp added on 2006-08-07 23:42:36:

File Added - 188039: cwdfinal.patch

Attachments: