Ticket UUID: | 1515234 | |||
Title: | Removing commas is slimming! | |||
Type: | Patch | Version: | None | |
Submitter: | afredd | Created on: | 2006-06-30 16:41:46 | |
Subsystem: | None | Assigned To: | kennykb | |
Priority: | 3 Low | Severity: | ||
Status: | Closed | Last Modified: | 2007-04-20 13:12:28 | |
Resolution: | Accepted | Closed By: | kennykb | |
Closed on: | 2007-04-20 06:12:28 | |||
Description: |
There are a large number of cases where string literals passsed to vararg functions are split over multiple lines but with a comma separating them. The most common are in calls to Tcl_AppendResult. By removing the comma separating the string literals, you save all round: * smaller object code (one less function argument to push) * one less '\0' in the strings table * faster run time (one less time round the varargs handling code) * smaller source code! Attached is a file containing all the occurences i could grep out of the Tcl source (there are more in Tk too) plus a patch for the first file in the list. I'll submit patches for the rest if someone's willing to apply them... although the changes are absurdly trivial :-) | |||
User Comments: |
kennykb added on 2007-04-20 13:12:28:
Logged In: YES user_id=99768 Originator: NO Sure, couldn't hurt. Unlikely to help much, but might as well put it in. afredd added on 2006-06-30 23:41:47: File Added - 183455: unnecesary_commas.txt |
Attachments:
- unnecesary_commas.txt [download] added by afredd on 2006-06-30 23:41:47. [details]