Ticket UUID: | 1424909 | |||
Title: | Tcl 8.4 does not build with VS2005. | |||
Type: | Bug | Version: | obsolete: 8.4.12 | |
Submitter: | chibi | Created on: | 2006-02-06 02:23:18 | |
Subsystem: | 53. Configuration and Build Tools | Assigned To: | patthoyts | |
Priority: | 2 | Severity: | ||
Status: | Closed | Last Modified: | 2011-04-21 13:43:02 | |
Resolution: | Fixed | Closed By: | nijtmans | |
Closed on: | 2011-04-21 06:43:02 | |||
Description: |
TCL could not be compiled in Visual Studio. Complete build log is attached. | |||
User Comments: |
nijtmans added on 2011-04-21 13:43:02:
allow_comments - 1 Let's continue this in [Bug #3288345] nijtmans added on 2011-04-19 19:27:42: Reopening for the following reason: I think that a different definition of Tcl_StatBuf for different VS versions is a bad idea: Tcl_StatBuf is part of the public Tcl API, and this prevents Tcl build with VS2005+ to work together with mingw-compiled extensions (or reverse), whenever the Tcl_StatBuf definition is involved. Here is a patch for Tcl 8.4 (1424909_2.patch), which fixes this: use _stati64 for all WIN32 platforms, no matter which compiler. This could be a potential incompatibility for VS2005+ builds, but because the 'standard' build is still MSVC6, in practice this is no problem at all. The same thing should be done for Tcl 8.5 and 8.6, but this patch is for 8.4 Agreed? nijtmans added on 2011-04-19 19:20:47: File Added - 409231: 1424909_2.patch patthoyts added on 2006-06-15 00:12:58: Logged In: YES user_id=202636 Committed the patch plus some extra code to merge in the .manifest files generated for msvcrt8. Further issues should be raised as win32 build system issues. patthoyts added on 2006-03-30 07:14:53: File Added - 172723: 1424909.patch patthoyts added on 2006-03-30 07:14:51: Logged In: YES user_id=202636 Attaching a patch that implements msvc8 support for the 8.4 branch. This produces no test failures on my system when compiling for win32. Trying to build for amd64 does not work though. patthoyts added on 2006-03-23 08:24:25: Logged In: YES user_id=202636 The patches applied to the development HEAD (8.5) have not yet been backported to 8.4 branch. In the meantime you should use msvc 6 or mingw gcc to compile on windows -- or obtain a prebuilt binary. chibi added on 2006-02-06 09:23:19: File Added - 166322: Win32_compile.zip |