Tcl Source Code

Since a4 a new string to number conversion technique
has been introduced. This new behaviour, in current
state,  can lead to severe program failures.

The question is, can it be considered valid for "string
is double" to return 0 (false) while shimmering the
Tcl_Obj in question to "double"?


The attached TCL snippet illustrates the problem.

Logged In: YES 
user_id=1312539

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

File Deleted - 160402:

File Added - 160407: 1382287.patch

Logged In: YES 
user_id=80530


updated patch includes
tests.  committing now, but
leaving assigned to kennykb
in case he wants further
review when back at work.

File Added - 160402: 1382287.patch

Logged In: YES 
user_id=80530


here's a patch that fixes
1382287 and 1360532.

still needs some test cases.

Logged In: YES 
user_id=80530


This is related to 1360532.

Both bugs arise because the
[string is] implementation
does its own scan checking
for trailing whitespace after
TclParseNumber returns.

The "right" solution may still
involve more revisions to the
TclParseNumber() interface.

Logged In: YES 
user_id=80530

% set x 2turtledoves
2turtledoves
% string is double $x
0
% string is double $x
1

Logged In: YES 
user_id=80530

Thanks for catching this.

File Added - 160060: a4numbers_bug.tcl

Logged In: YES 
user_id=148712

No file is attached.