| Ticket UUID: | 1380662 | |||
| Title: | Tcl_StackChannel doesn't permit NULL interp | |||
| Type: | Bug | Version: | obsolete: 8.4.12 | |
| Submitter: | dgp | Created on: | 2005-12-14 18:51:12 | |
| Subsystem: | 25. Channel System | Assigned To: | dgp | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2006-02-15 23:04:49 | |
| Resolution: | Fixed | Closed By: | dgp | |
| Closed on: | 2006-02-15 16:04:37 | |||
| Description: |
Tcl_StackChannel() takes an interp argument as a place to write error messages, but doesn't follow the usual practice of accepting a NULL value. This need for non-NULL interp can cascade up, forcing Tcl_FSOpenFileChannel() to need a non-NULL interp as well. | |||
| User Comments: |
dgp added on 2006-02-15 23:04:49:
File Added - 167560: 1380662-84.patch dgp added on 2006-02-15 23:04:36: Logged In: YES user_id=80530 also committing this version of the patch to the 8-4-branch. dgp added on 2006-02-15 22:44:46: Logged In: YES user_id=80530 committed to HEAD dgp added on 2006-02-10 03:42:49: File Deleted - 159875: File Added - 166829: 1380662.patch dgp added on 2006-02-10 03:42:48: Logged In: YES user_id=80530 Revised patch ready for review. dgp added on 2005-12-19 23:13:40: Logged In: YES user_id=80530 good points from dkf: avoid Tcl_Panic() if possible TclChanCaughtErrorBypass() can't seem to make up its mind whether it can handle NULL interp, it should be made to. dgp added on 2005-12-15 03:21:33: File Deleted - 159873: dgp added on 2005-12-15 03:21:32: File Added - 159875: 1380662.patch Logged In: YES user_id=80530 attached patch takes care of everything I could find. dgp added on 2005-12-15 02:32:30: Logged In: YES user_id=80530 Tcl_Close() and Tcl_UnstackChannel() have similar issue, but appear trickier to untangle. dgp added on 2005-12-15 01:59:15: File Added - 159873: 1380662.patch dgp added on 2005-12-15 01:59:13: Logged In: YES user_id=80530 I believe the attached patch corrects the problem. | |||
Home
Timeline
Branches
Tags
Tickets
Download
Wiki