Tcl Source Code

The code building the fully qualified namespace name in 
Tcl_CreateNamespace unnecesarily copies buffer1 and 
buffer2 back and forth. By using Tcl_DString pointers, 
you can swap pointers instead of copying one buffer to 
the other. This saves a call to TclDStringSetLength & 
one to Tcl_DStringAppend. Also the strlen(name) can be 
avoided as we have the DString's length.
Patch also includes some other minor efficiency 
changes.

(the patch is against 8.5a3)

Logged In: YES 
user_id=1386588

(afredd)
It looks like a line of code got lost from the patch
in 1.96: the "buffPtr" DString needs to be cleared
before it is used each time. Currently it works for
two part namespaces eg. "::tcl::mathfunc", but will
generate a bad name if there are more parts.
This will fix it:

--- tclNamesp.c-orig    2006-08-11 15:28:55.203125000 +0100
+++ tclNamesp.c 2006-08-11 15:29:44.890625000 +0100
@@ -854,6 +854,7 @@
        if (ancestorPtr != globalNsPtr) {
            register Tcl_DString *tempPtr = namePtr;

+           Tcl_DStringSetLength(buffPtr, 0);
            Tcl_DStringAppend(buffPtr, "::", 2);
            Tcl_DStringAppend(buffPtr, ancestorPtr->name, -
1);
            Tcl_DStringAppend(buffPtr, Tcl_DStringValue
(namePtr),

File Added - 155584: tclNamesp.c.patch