| Ticket UUID: | 1267256 | |||
| Title: | enable static linking when TclX is present | |||
| Type: | Patch | Version: | None | |
| Submitter: | matt-newman | Created on: | 2005-08-23 16:28:02 | |
| Subsystem: | 80. Thread Package | Assigned To: | vasiljevic | |
| Priority: | 7 High | Severity: | ||
| Status: | Open | Last Modified: | 2007-06-14 00:32:46 | |
| Resolution: | Remind | Closed By: | vasiljevic | |
| Closed on: | 2005-08-24 06:35:02 | |||
| Description: |
When you statically link the thread extension w/ the TclX extension you get multiple defines - this patch addresses this issue in a minimal impact way. | |||
| User Comments: |
vasiljevic added on 2005-08-25 03:18:14:
Logged In: YES user_id=95086 I took pieces out the TclX for about 2 years ago. I will look into your changes and sync them in. Thanks for the hint. hobbs added on 2005-08-25 00:25:32: Logged In: YES user_id=72656 I don't know when tclXkeylist.c was forked, but I updated the TclX version with some mods that significantly improve performance on large keylists. You might also consider those when making changes. vasiljevic added on 2005-08-24 20:17:59: Logged In: YES user_id=95086 aha... ok. lets do those as well... matt-newman added on 2005-08-24 20:11:54: Logged In: YES user_id=1333796 Thanks for making this change, however unfortunately I was not complete in the list of public symbols that class, the complete list - verified by using NM on the resultant objects is: #define tclXWrongArgs thread_tclXWrongArgs #define TclX_WrongArgs thread_TclX_WrongArgs #define TclX_AppendObjResult thread_TclX_AppendObjResult #define TclX_IsNullObj thread_TclX_IsNullObj #define TclX_KeyedListDelete thread_TclX_KeyedListDelete #define TclX_KeyedListGet thread_TclX_KeyedListGet #define TclX_KeyedListGetKeys thread_TclX_KeyedListGetKeys #define TclX_KeyedListInit thread_TclX_KeyedListInit #define TclX_KeyedListSet thread_TclX_KeyedListSet #define TclX_NewKeyedListObj thread_TclX_NewKeyedListObj vasiljevic added on 2005-08-24 13:35:02: Logged In: YES user_id=95086 Checked into CVS head branch. Instead of the proposed patch I made those symbols static in the tclXkeylist.c file. This should do. vasiljevic added on 2005-08-24 02:07:12: Logged In: YES user_id=95086 Thanks for the update. I will rather declare those as static in the tclXkeylist.c because those are only used from within that file. I will checkin the fix tomorrow in the cvs head branch. matt-newman added on 2005-08-23 23:28:03: File Added - 146694: x | |||
Attachments:
- x [download] added by matt-newman on 2005-08-23 23:28:02. [details]