Tcl Source Code

View Ticket
Login
Ticket UUID: 1264637
Title: NO_ERRNO_H
Type: Bug Version: obsolete: 8.5a4
Submitter: dgp Created on: 2005-08-20 05:16:54
Subsystem: 47. Bytecode Compiler Assigned To: dgp
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2005-10-14 01:30:28
Resolution: Fixed Closed By: dgp
    Closed on: 2005-10-13 18:30:28
Description:
Both tclUnixPort.h and
tclWinPort.h unconditionally
#include <errno.h>.

In the few places where
NO_ERRNO_H is tested,
there's really no point, because
by then we've already included
errno.h, or had a compiler failure.

Seems all the pretense of
honoring NO_ERRNO_H
can be abandoned, along with
attempts to make use of
an internal-to-Tcl errno variable
(based in tclExecute.c).
User Comments: dgp added on 2005-10-14 01:30:28:
Logged In: YES 
user_id=80530

committed to HEAD

dgp added on 2005-10-14 01:27:39:

File Deleted - 149893: 



File Added - 152422: 1264637.patch

dgp added on 2005-10-14 01:27:38:
Logged In: YES 
user_id=80530


updated patch
(post-237 merge)

dgp added on 2005-09-21 22:21:23:

File Added - 149893: 1264637.patch

dgp added on 2005-09-21 22:21:12:
Logged In: YES 
user_id=80530


here's a patch.

jenglish added on 2005-09-21 21:10:50:
Logged In: YES 
user_id=68433

> Seems all the pretense of honoring NO_ERRNO_H can be
abandoned,

That would be safe to do.

> along with attempts to make use of an internal-to-Tcl
errno variable

That would be a very good idea.

Attachments: