Ticket UUID: | 1252107 | |||
Title: | Channel transfer, extended testsuite | |||
Type: | Patch | Version: | None | |
Submitter: | andreas_kupries | Created on: | 2005-08-04 18:30:19 | |
Subsystem: | 25. Channel System | Assigned To: | andreas_kupries | |
Priority: | 6 | Severity: | ||
Status: | Open | Last Modified: | 2005-08-13 09:08:18 | |
Resolution: | None | Closed By: | ||
Closed on: | ||||
Description: |
The attached patch is something I have sitting in my sandbox for TIP #219 for some time now. It extends the tcltest code with a very minimal attach/detach facility, as Threads has it, and then uses it for basic testing of transfering of channel transfer in the core testsuite. The package Thread has some testing of this as well, however and IMHO everything the core provides should be tested by the core testsuite as well, otherwise it will be forgotten. The tests in the patch do _not_ test the scenarios which have come up on tcl-core in the last few days, but might be able to. An initial step to improve this area. Should maybe try to write an 'after-the-fact-TIP' for the facility to give it some specification we can follow. Please review. | |||
User Comments: |
dgp added on 2005-08-13 09:08:18:
Logged In: YES user_id=80530 other than that compiler warning, the patch applies, builds, and tests fine, both with and without threads. gave the code a very brief look and saw nothing to object to. Our quality bar isn't very high in the *Test*.c files. They tend to be a mishmash of whatever was needed to get a test done, and that's fine. dgp added on 2005-08-13 09:01:00: Logged In: YES user_id=80530 ./unix/../generic/tclThreadTest.c ../generic/tclThreadTest.c: In function `NewTestThread': ../generic/tclThreadTest.c:487: warning: implicit declaration of function `Tcltest_Init' andreas_kupries added on 2005-08-05 01:30:19: File Added - 144448: transfer.patch |
Attachments:
- transfer.patch [download] added by andreas_kupries on 2005-08-05 01:30:19. [details]