Tcl Source Code

Received from Patrick Fradin [patrick.fradin at
synelec.fr]:

(Tk submitted separately)

I made next modifications joined in 2 archives :

    - Always use eq / ne to compare strings instead of
string equal, string match, string compare, == and so
on... I think it's simplify code readability and
maintenance.

    - Replace some simple regsub with string map to
improve exec performance

    - Replace some simple regexp with string match for
the same reasons

    - Use unset -nocomplain to avoid if info exists or
catch

    - Use trace add variable write/unset instead of old
trace variable w/u

    - Use trace remove variable instead of old trace
vdelete

    - Use trace info variable instead of old trace vinfo

    - use [list] to initialize empty list instead of ""
or {} string

    - Avoid code abbreviations to clarify code and
avoid reading errors

        ex: string len -> string length
            $w config  -> $w configure ...

    - Replace some simple eval $cmd commands with
"compiled" if 1 $cmd
(speedier)

    - Use foreach to parse values instead of many
lindex (ex: clrpick.tcl)

    - Replace regexp "dummy" variable with "->" to
improve readability

    - I remarked some catch {destroy $w}. I think it's
useless, isn't it ?

Logged In: YES 
user_id=80530

Appropriate portions applied
to HEAD for 8.5a4 as well.

Logged In: YES 
user_id=80530


changed !! operations to ! ...
dropped ldAout.tcl changes...

committed for 8.4.12.

File Deleted - 142734: 



File Added - 142844: 1237755.patch

Logged In: YES 
user_id=80530

Updated patch does all the things
from the checklist that I find
appropriate and worthwhile.

File Deleted - 142623: 



File Added - 142734: 1237755.patch

Logged In: YES 
user_id=80530


First pass does the first
bullet point only.

Logged In: YES 
user_id=80530


re-opening with the intent to
abandon the contributed patches
and work through the initial comment
checklist instead.

Logged In: YES 
user_id=80530


The revised patch still has
far too much extraneous whitespace
changes; making it too much work
to find and review the changes of
substance sprinkled here and there
within the huge patch.

Since this patch doesn't fix any bugs,
I can't justify the review effort.

If the substantive changes can be
resubmitted as a cleaner patch,
or even a series of smaller focused
patches, that would be welcome.

File Deleted - 142607: 



File Added - 142623: 1237755.patch

Logged In: YES 
user_id=80530


Here's an improved version
in patch form with the
worst indenting incompatibilities
removed.

File Added - 142607: 1237755.patch

Logged In: YES 
user_id=80530


Here's the same change set as
a patch against core-8-4-branch.

Unfortunately, the submitted code
used a different indexing style, so
the patch depicts far more extensive
changes than are real.

data_type - 310894

File Added - 141967: tcl8.4.11_library.tgz