Tcl Source Code

Given

  char *buf;
  long l;

it appears that

TclFormatInt(buf, l);

is the equivalent of

sprintf(buf, "%ld", l);

Therefore, I request to make
TclFormatInt a macro, #define'd
in tclInt.h :

  #define TclFormatInt(buf, l)  sprintf((buf), "%ld", (l))

Some compatibility provisions can be
made for the internal stubs table slot
currently occupied by the TclFormatInt
routine.

The comments of TclFormatInt allege:

 *      ...This
 *      procedure has the effect of sprintf(buffer,
"%d", n) but is faster.

Frankly, I don't believe that.  (Even ignoring the
"d" for "ld" error.)

Just to note this change was reverted for 8.6 and 8.5.10 on 2010-11-30 after benchmarks proved TclFormatInt to be faster.  This is key to Tcl's int->string conversions, and the win is likely primarily in sprintf not needing to parse the "%ld" format.

File Added - 140953: 1194015.patch

Logged In: YES 
user_id=80530


committing the attached patch
to HEAD.

Logged In: YES 
user_id=68433

One possible problem area:  because of the function
prototype, at any call sites that currently pass an 'int' as
the second parameter it will be silently promoted to 'long';
if TclFormatInt() is replaced with a macro this will no
longer happen.

Also: this would introduce another dependency on <stdio.h>.
 This probably isn't a big deal since <tcl.h> already
#includes it and there are a bunch of other dependencies
already.