| Ticket UUID: | 1112654 | |||
| Title: | eliminate double substitution from configure.in | |||
| Type: | RFE | Version: | None | |
| Submitter: | jenglish | Created on: | 2005-01-30 17:28:12 | |
| Subsystem: | 85. tclconfig | Assigned To: | hobbs | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2010-08-14 03:13:20 | |
| Resolution: | Fixed | Closed By: | hobbs | |
| Closed on: | 2010-08-13 20:13:20 | |||
| Description: |
MSW reports (on the chat) that latest changes to configure.in / tcl.m4 (#1081595) break the build on NetBSD. Problem: "configure produces makefile targets like libtcl`echo ... | tr -d ...`". | |||
| User Comments: |
hobbs added on 2010-08-14 03:13:20:
allow_comments - 1 dgp added on 2005-06-02 05:28:57: Logged In: YES user_id=80530 the remaining request here (re-opening) is to get rid of any remaining "eval"s in configure.in / tcl.m4 . Most of the eval's were there originally to substitute $(TCL_DBGX), but that's gone now. so they ought to be able to go too. The presence of eval's makes it more difficult to solve the problem of handling spaces in pathnames (554348). jenglish added on 2005-06-01 00:10:24: Logged In: YES user_id=68433 > Is there anything here to fix? Not that I'm aware of. It would be _nice_ to get rid of all the double-evals in configure.in, but not _necessary_ afaict. hobbs added on 2005-05-31 08:51:40: Logged In: YES user_id=72656 Is there anything here to fix? dgp added on 2005-01-31 23:26:43: data_type - 360894 Logged In: YES user_id=80530 Committed the generated unix/configure file. Moving this report over to a Feature Request. Let us please find a way to solve these problems without using an "eval". Getting rid of the double substitution was going to be an important step toward fixing Bug 553544. jenglish added on 2005-01-31 01:44:42: Logged In: YES user_id=68433 Reopening -- I have autoconf 2.59, not 2.57, so can't regenerate the configure script. Jeff, could you take care of this? Thanks. (BTW, why are we using 2.57?) jenglish added on 2005-01-31 01:39:32: Logged In: YES
user_id=68433
Patch confirmed. Also checked tk/unix/configure.in for
similar issues; no double-evals were removed in the DBGX
purge, Tk CVS HEAD compiles OK on NetBSD.
What's not clear is whether NetBSD even needs to use
${TCL_TRIM_DOTS} anymore, but that's an issue for another time.
jenglish added on 2005-01-31 01:04:46: File Deleted - 117800: File Added - 117806: tcl-1112654.patch jenglish added on 2005-01-31 00:58:12: Logged In: YES
user_id=68433
Followup: Double-eval is also required for TCL_STUB_LIB_FILE.
We should really consider handling this TCL_TRIM_DOTS /
TCL_LIB_VERSIONS_OK / TCL_{UN}SHARED_LIB_SUFFIX mess
differently.
jenglish added on 2005-01-31 00:33:25: File Added - 117800: tcl-1112654.patch jenglish added on 2005-01-31 00:33:24: Logged In: YES
user_id=68433
Probable cause of the problem: the line
| eval "TCL_LIB_FILE=${TCL_LIB_FILE}"
(configure.in r1.125 line 448), which was removed in r1.126,
is actually used for more than just expanding ${TCL_DBGX}.
In particular, if TCL_LIB_VERSIONS_OK is set to "nodots", it
contains other shell escapes.
Attached patch attempts to fix the problem by restoring this
line.
| |||
Attachments:
- tcl-1112654.patch [download] added by jenglish on 2005-01-31 01:04:46. [details]