Tcl Source Code

View Ticket
Login
Ticket UUID: 1081595
Title: Die, DBGX, die
Type: Patch Version: TIP Implementation
Submitter: jenglish Created on: 2004-12-08 20:10:21
Subsystem: 53. Configure and Build Tools Assigned To: jenglish
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2005-01-11 01:59:03
Resolution: Accepted Closed By: jenglish
    Closed on: 2005-01-10 18:59:03
Description:
As recommended by TIP #34, the attached patch removes
${TCL_DBGX} and ${DBGX} from Tcl's build system.  This
no longer serves a useful purpose (if it ever did).

Rerun 'autoconf' after applying the patch (diff to
'configure' script not included).
User Comments: jenglish added on 2005-01-11 01:59:02:
Logged In: YES 
user_id=68433

Committed to tcl and tk CVS HEAD; re-synced tk/unix/tcl.m4
with tcl/unix/tcl.m4.

jenglish added on 2004-12-30 06:47:57:
Logged In: YES 
user_id=68433

Committed tea-die-dbgx-die.patch.  This only affects the
sample extension, and any future TEA extensions that copy
tcl.m4 from the sampleextension CVS HEAD.

jenglish added on 2004-12-10 04:41:57:
Logged In: YES 
user_id=68433

Re: widening the gap between the Windows and Unix world --
it would be an astonishingly good idea to remove TCL_DBGX
from the Windows build system too.  I haven't done that
simply because I don't have access to a Windows machine that
I can test on.

jenglish added on 2004-12-10 04:37:50:

File Deleted - 111729: 



File Added - 111899: tcl-die-dbgx-die.patch

Logged In: YES 
user_id=68433

Oops!  Sorry, forgot to include that file in the patch.  New
patch fixes.
Additional diffs:

26,28c26,28
< # If TCL was built with debugging symbols, generated
libraries contain
< # this string at the end of the library name (before the
extension).
< TCL_DBGX=@TCL_DBGX@
---
> # TCL_DBGX used to be used to distinguish debug vs.
non-debug builds.
> # This was a righteous pain so the core doesn't do that
any more.
> TCL_DBGX=

dgp added on 2004-12-09 23:45:12:
Logged In: YES 
user_id=80530


even better, follow what you did
for Tk and just hardwire the
value to the empty string.

dgp added on 2004-12-09 23:32:03:
Logged In: YES 
user_id=80530


shouldn't the TCL_DBGX line
in unix/tclConfig.sh.in be removed
as well?

As is, the generated tclConfig.sh file
contains:

TCL_DBGX=@TCL_DBGX@

and I doubt any other code can make
sense of that.  Wouldn't a missing value
be better than a nonsense one?

dkf added on 2004-12-09 05:31:34:
Logged In: YES 
user_id=79902

Hmm, I'm not at all sure about the impact on the widening of
the gap between the unix and win worlds that this would have.

jenglish added on 2004-12-09 03:46:31:

File Added - 111732: tea-die-dbgx-die.patch

jenglish added on 2004-12-09 03:46:30:
Logged In: YES 
user_id=68433

... and the same thing for the sample extension.  TEA still
needs to account for the possibility that ${TCL_DBGX} is
referenced in tclConfig.sh, but there's no reason for
extensions to add a ${DBGX} suffix to their own shared
libraries.

jenglish added on 2004-12-09 03:23:46:

File Added - 111730: tk-die-dbgx-die.patch

Logged In: YES 
user_id=68433

... and the same for Tk.  It looks like Tk's copy of tcl.m4
has gotten out of sync with Tcl's; the tk patch also resyncs
them.

jenglish added on 2004-12-09 03:10:21:

File Added - 111729: tcl-die-dbgx-die.patch

Attachments: