Tcl Source Code

consider storing the shared
tcl_precision value as a
ProcessGlobalValue.

File Deleted - 141223:

File Added - 143518: 1077229.patch

Logged In: YES 
user_id=80530


Committing updated patch to HEAD.

File Added - 141223: 1077229.patch

Logged In: YES 
user_id=80530


Attached patch makes the
tcl_precision a per-thread value.

Advantage is that surprises like

    set tcl_precision 5
    <another thread sets tcl_precision to something else>
    puts $myDouble

are avoided.

Disadvantage is those misquided souls
who believe they want a different value
of tcl_precision that the default (0) now
have to set it in each thread, not just
once per app.

please review

Logged In: YES 
user_id=80530


...though T_PD must handle,
and most often sees, a value
of interp == NULL passed in.

Logged In: YES 
user_id=80530


ummm.... FWIW, Tcl_PrintDouble
*does* appear to accept an interp
argument.

Logged In: YES 
user_id=80530


how about storing tcl_precision
per-thread rather than app-wide?

Almost seems that we have to do
that, or else the whole process
of formatting doubles is not
"thread-safe" in a rather important
sense.

Logged In: YES 
user_id=99768

Storing tcl_precision per-interp rather than
process wide doesn't work, because Tcl_PrintDouble
doesn't take an interp as a parameter.  Alas.

Logged In: YES 
user_id=80530


I'd like your comment on this,
and on the related idea of 
storing tcl_precision per-interp
instead of sharing app-wide.