| Ticket UUID: | 1055676 | |||
| Title: | Crash in test suite | |||
| Type: | Bug | Version: | obsolete: 8.5a2 | |
| Submitter: | dkf | Created on: | 2004-10-27 22:03:35 | |
| Subsystem: | 47. Bytecode Compiler | Assigned To: | msofer | |
| Priority: | 9 Immediate | Severity: | ||
| Status: | Closed | Last Modified: | 2004-10-29 00:22:25 | |
| Resolution: | Fixed | Closed By: | msofer | |
| Closed on: | 2004-10-28 17:22:25 | |||
| Description: |
Tcl HEAD on Fedora Core/Athlon, configured
--enable-symbols=all
make test "TESTFLAGS=-singleproc 1 -file [rs]*.test"
... leads to (no other complaints) ...
stack.test
Bad stack top -586884 at pc 949 in TclExecuteByteCode
(min 3, max 12)
executing foreach file [lsort [GetMatchingFiles]] {
set tail [file tail $file]
puts [outputChannel] $tail...
TclExecuteByteCode execution failure: bad stack top
make: *** [test] Error 134
Cannot duplicate by just testing all the r*.tests or
just the s*.tests. :^(
| |||
| User Comments: |
msofer added on 2004-10-29 00:22:25:
Logged In: YES user_id=148712 Thanks Don! New test execute-8.3 and patch committed to HEAD. dgp added on 2004-10-28 22:29:20: Logged In: YES user_id=80530 Yeah, get right on that, miguel. dkf added on 2004-10-28 22:25:15: Logged In: YES user_id=79902 Cool. Create a test that exercises the problem (and demonstrates that the fix works) and apply away. :^) dgp added on 2004-10-28 21:58:10: File Added - 106829: 1055676.patch dgp added on 2004-10-28 21:58:09: Logged In: YES user_id=80530 here's the patch that fixes the problem. dgp added on 2004-10-28 21:44:09: Logged In: YES user_id=80530 rename.test includes rename list l.new outside of any test. Since this is a rename of a compiled command, the compile Epoch is bumped. Because of -singleproc 1, this invalidates the bytecode of the tcltest::runAllTests proc, and the next INST_START_CMD bytecode causes bytecode execution to be replaced by direct script evaluation. The crash happens after that. dkf added on 2004-10-28 05:44:45: Logged In: YES user_id=79902 Still crashes if I add '-match stack-3.1' to that command line! None of the tests in rename.test (or the other tests in stack.test) need to be executed for stack.test to fail dkf added on 2004-10-28 05:28:58: Logged In: YES user_id=79902 Narrowed it down to: make test "TESTFLAGS=-singleproc 1 -file 'rename.test stack.test'" Seem to require *both* test files to fail. | |||
Attachments:
- 1055676.patch [download] added by dgp on 2004-10-28 21:58:09. [details]