Tcl Source Code

View Ticket
Login
Ticket UUID: 1053568
Title: tm.test failures
Type: Bug Version: obsolete: 8.5a2
Submitter: patthoyts Created on: 2004-10-25 07:58:42
Subsystem: 38. Init - Library - Autoload Assigned To: andreas_kupries
Priority: 9 Immediate Severity:
Status: Closed Last Modified: 2004-11-05 16:22:47
Resolution: Fixed Closed By: andreas_kupries
    Closed on: 2004-10-27 17:29:31
Description:
tm.test

==== tm-1.2 tm: path command syntax FAILED
==== Contents of test case:

    ::tcl::tm::path FIXME

---- Test generated error; Return code was: 1
---- Return code should have been one of: 0 2
---- errorInfo: Expect one of add, remove, or list, got
"FIXME"
    while executing
"::tcl::tm::path FIXME"
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $script"
---- errorCode: NONE
==== tm-1.2 FAILED


==== tm-1.2 tm: roots command syntax FAILED
==== Contents of test case:

    ::tcl::tm::roots

---- Test generated error; Return code was: 1
---- Return code should have been one of: 0 2
---- errorInfo: wrong # args: should be
"::tcl::tm::roots paths"
    while executing
"::tcl::tm::roots"
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $script"
---- errorCode: NONE
==== tm-1.2 FAILED
User Comments: dkf added on 2004-11-05 16:22:47:
Logged In: YES 
user_id=79902

Added a [file normalize] to genpaths.  Thanks for reporting
the issue.

wildcard_25 added on 2004-11-05 09:41:38:
Logged In: YES 
user_id=596509

Tk: v8.5a2
OS: WinXPsp2
Built with makefile.vc using VC7.1

Changing /FOO to [file normalize /FOO] in the test result 
generation fixes this on windows. The same for /BAR.

==== tm-3.12 tm: module path management, roots FAILED
==== Contents of test case:

    ::tcl::tm::roots /FOO
    ::tcl::tm::path list

---- Result was:
D:/FOO/site-tcl D:/FOO/tcl8/8.0 D:/FOO/tcl8/8.1
D:/FOO/tcl8/8.2 D:/FOO/tcl8/8.3 D:/FOO/tcl8/8.4
D:/FOO/tcl8/8.5
---- Result should have been (exact matching):
/FOO/site-tcl /FOO/tcl8/8.0 /FOO/tcl8/8.1
/FOO/tcl8/8.2 /FOO/tcl8/8.3 /FOO/tcl8/8.4
/FOO/tcl8/8.5
==== tm-3.12 FAILED


==== tm-3.13 tm: module path management, roots FAILED
==== Contents of test case:

    ::tcl::tm::roots [list /FOO /BAR]
    ::tcl::tm::path list

---- Result was:
D:/BAR/site-tcl D:/BAR/tcl8/8.0 D:/BAR/tcl8/8.1
D:/BAR/tcl8/8.2 D:/BAR/tcl8/8.3 D:/BAR/tcl8/8.4
D:/BAR/tcl8/8.5 D:/FOO/site-tcl D:/FOO/tcl8/8.0
D:/FOO/tcl8/8.1 D:/FOO/tcl8/8.2 D:/FOO/tcl8/8.3
D:/FOO/tcl8/8.4 D:/FOO/tcl8/8.5
---- Result should have been (exact matching):
/BAR/site-tcl /BAR/tcl8/8.0 /BAR/tcl8/8.1
/BAR/tcl8/8.2 /BAR/tcl8/8.3 /BAR/tcl8/8.4
/BAR/tcl8/8.5 /FOO/site-tcl /FOO/tcl8/8.0
/FOO/tcl8/8.1 /FOO/tcl8/8.2 /FOO/tcl8/8.3
/FOO/tcl8/8.4 /FOO/tcl8/8.5
==== tm-3.13 FAILED

andreas_kupries added on 2004-10-28 00:29:31:
Logged In: YES 
user_id=75003

Committed to CVS head.

andreas_kupries added on 2004-10-27 23:51:33:
Logged In: YES 
user_id=75003

Here is a variant of my first patch. Slightly different,
packs the generation into a proc.

andreas_kupries added on 2004-10-27 23:49:10:

File Added - 106708: 1053568.patch.2

dgp added on 2004-10-27 22:09:12:

File Added - 106697: 1053568.patch

Logged In: YES 
user_id=80530

here's a modified patch.

review and apply.

dgp added on 2004-10-27 06:29:50:
Logged In: YES 
user_id=80530


tests tm-3.12 and tm-3.13 require
maintenance.  Would be better to
construct their expected result, I think.

andreas_kupries added on 2004-10-27 05:52:22:
Logged In: YES 
user_id=75003

Please review.

andreas_kupries added on 2004-10-27 05:51:32:

File Added - 106600: 1053568.patch

Logged In: YES 
user_id=75003

Here are some tests. They also found a bug, and this bug is
fixed in this patch as well.

dkf added on 2004-10-25 15:37:09:
Logged In: YES 
user_id=79902

I checked these tests in (which are known to fail), mostly
because they are a hole in the current test regime that
needs filling.

Increasing the priority to "Block Release" level; this
*must* be fixed (by creation of appropriate tests!) before
release. DO NOT FIX BY MARKING AS KNOWNBUG.

patthoyts added on 2004-10-25 14:59:50:
Logged In: YES 
user_id=202636

Doh! Forgot to add that this is Windows XP, todays HEAD as
of 08:00 GMT

Attachments: