Tcl Source Code

This makes Tcl_AppendResultVA (and hence
Tcl_AppendResult) more suitable for the Tcl_Obj world :^)

Does not touch the rest of the file.

Logged In: YES 
user_id=79902

Since that only adversely affects ancient apps that insist
on fiddling with interp->result directly (Expect is such an
app still AIUI), I've just removed the call to
Tcl_GetStringResult(). Anyone who really wants it in (and
who has read this thread carefully so they understand the
consequences) can define the preprocessor symbol
USE_DIRECT_INTERP_RESULT_ACCESS when building tclResult.c...

Logged In: YES 
user_id=80530


As an alternative to an undo,
simply removing the final
Tcl_GetStringResult() call
from Tcl_AppendResultVA
also restores the lost performance.

That is, that monumental runtime
price is paid solely to maintain
interp->result.

File Added - 109141: undo.patch

Logged In: YES 
user_id=80530


The [$canvas postscript] command
creates the postscript description
of the $canvas contents directly
in the interp result with calls to
Tcl_AppendResult().

The canvPs-3.1 test makes tens of
thousands of T_AR calls.

WIthout this patch, those tens of
thousands of calls happen in 
the blink of an eye.  With this patch,
they take > 30 seconds.

Since the intent of this patch
was to make things more efficient,
I think it's not working and should
be reverted.

Attached is an "undo" patch that
will do that.

Logged In: YES 
user_id=80530


This patch killled the performance
of Tk test canvPs-3.1.  See Tk
Bug 1041475.

Logged In: YES 
user_id=80530

backport?

Logged In: YES 
user_id=79902

Accepted with minor modifications (thanks jenglish and dgp!)

File Added - 103960: result.diff