Tcl Source Code

This patch speeds up [uplevel] and [upvar] by caching
the result of parsing the string form of the level
indicator in the Tcl_Obj argument instead of always
working with the string form for everything.

Logged In: YES 
user_id=79902

Applied to HEAD

Logged In: YES 
user_id=80530

revised patch tests ok.

File Deleted - 103249:

File Added - 103339: 1037357_2.patch

Logged In: YES 
user_id=79902

Here's a version that shouldn't have problems with
shimmering all over the place.  Causes no new test failures.
 No idea (formally) what happens in tclbench, but looks good
in informal trials. ;^)

Logged In: YES 
user_id=79902

Thanks for the review; I'll have to write a new version that
is aware of numeric types and avoids the conversion in those
situations. I suspected I needed to do this anyway ;^)

Logged In: YES 
user_id=80530


This patch should be checked
against tclbench.  I suspect that
whatever is being saved by
repeated use of $level by 
multiple [uplevel]s and [upvar]s
is more than being lost by
the greatly increased shimmering of
the literal constant "1" in so many
logical expressions.

`make test` sure feels a lot slower anyway.

Logged In: YES 
user_id=80530


Root of the problem appears to
be line 1965 of tcltest.tcl where
the literal "1" appears twice.
First as the "level" argument
to [uplevel] and second as an
argument in the command to
be evaluated up a level.  Something
isn't shimmering right, I'd suspect.

As a check, if I remove the second "1"
from that line (and accept the default
value of that argument, which is 1),
then the problem goes away.

Logged In: YES 
user_id=80530

something about the patch
breaks tcltest:

dict.test
Test file error: can't rename "::tcltest::Replace::Puts":
command doesn't exist
    while executing
"rename [namespace current]::Replace::Puts ::puts"
    (procedure "::tcltest::Eval" line 16)
    invoked from within
"::tcltest::Eval {::tcltest::RunTest dict-18.2 {# Test that
the dictionary is a valid list
        set d [dict create "abc def" 0 "a\{b" 1 "c\}d" 2]
  ..."
    ("uplevel" body line 1)
    invoked from within
"uplevel 1 [list [namespace origin Eval] $command 1]"
    (procedure "test" line 126)
    invoked from within
"test dict-18.2 {dict-list relationship} {
    -body {
        # Test that the dictionary is a valid list
        set d [dict create "abc def" 0 "a\{b"..."
    (file "/local/src/tcl/tests/dict.test" line 726)

File Deleted - 103256: 



File Added - 103261: 1037357.patch

Logged In: YES 
user_id=80530

updated patch takes care of comments
and allows `make genstubs` to succeed.

Logged In: YES 
user_id=80530

The comments in Tcl*GetFrame
say "modify the interpreter", but
neither routine actually does that.

File Added - 103256: 1037357.patch

Logged In: YES 
user_id=80530

corrected  patch applies and compiles.

File Added - 103249: objup.diff